Allows to show display settings for 1-display of stumpy.

Allows to show display settings for 1-display of stumpy.

The old code just checks the number of displays and shows the settings
only when there're 2>= displays. However we may want to provide the
display settings when only one display is connected to stumpy. That's
because the user may want to calibrate the display overscan for the
single display.

In the new code, the display settings is visible only when there is
at least one external display, so the behavior is same on chromebooks
but the settings will be visible on stumpy.

BUG=172936
TEST=Display settings is visible on chromeos-chrome on Goobuntu

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179982

[oshima, 2013-01-31 02:32:40]

https://codereview.chromium.org/12088081/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/12088081/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:157: }
You should be able to tell if there is an external display by

has_external = !DisplayManager::HasInternalDisplay() || num_display > 1

and i think it'll make this CL smaller?

[Jun Mukai, 2013-01-31 02:40:10]

https://codereview.chromium.org/12088081/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/12088081/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:157: }
On 2013/01/31 02:32:40, oshima wrote:
> You should be able to tell if there is an external display by
> 
> has_external = !DisplayManager::HasInternalDisplay() || num_display > 1
> 
> and i think it'll make this CL smaller?

indeed. done.

[oshima, 2013-01-31 02:46:07]

lgtm with optional nit

https://codereview.chromium.org/12088081/diff/7001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/12088081/diff/7001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:141: size_t
min_displays = display_manager->HasInternalDisplay() ? 2 : 1;
may be 

min_displays_to_show

[Jun Mukai, 2013-01-31 18:58:19]

https://codereview.chromium.org/12088081/diff/7001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/12088081/diff/7001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:141: size_t
min_displays = display_manager->HasInternalDisplay() ? 2 : 1;
On 2013/01/31 02:46:07, oshima wrote:
> may be 
> 
> min_displays_to_show

Done.

[commit-bot: I haz the power, 2013-01-31 19:36:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/12088081/5

[commit-bot: I haz the power, 2013-01-31 21:57:37]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...