Chromium Code Reviews
Help | Chromium Project | Sign in
(173)

Issue 12088081: Allows to show display settings for 1-display of stumpy. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Jun Mukai
Modified:
1 year, 2 months ago
CC:
chromium-reviews_chromium.org, dbeam+watch-options_chromium.org, arv, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Allows to show display settings for 1-display of stumpy.

The old code just checks the number of displays and shows the settings
only when there're 2>= displays. However we may want to provide the
display settings when only one display is connected to stumpy. That's
because the user may want to calibrate the display overscan for the
single display.

In the new code, the display settings is visible only when there is
at least one external display, so the behavior is same on chromebooks
but the settings will be visible on stumpy.

BUG=172936
TEST=Display settings is visible on chromeos-chrome on Goobuntu

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179982

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : fix a silly typo #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Lint Patch
M chrome/browser/resources/options/chromeos/display_options.js View 1 chunk +8 lines, -1 line 0 comments ? errors Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 2 3 1 chunk +5 lines, -1 line 0 comments 0 errors Download
Commit:

Messages

Total messages: 7
Jun Mukai
1 year, 2 months ago #1
oshima (OOO April 11 - 21)
https://codereview.chromium.org/12088081/diff/1/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc (right): https://codereview.chromium.org/12088081/diff/1/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc#newcode157 chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:157: } You should be able to tell if there ...
1 year, 2 months ago #2
Jun Mukai
https://codereview.chromium.org/12088081/diff/1/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc (right): https://codereview.chromium.org/12088081/diff/1/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc#newcode157 chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:157: } On 2013/01/31 02:32:40, oshima wrote: > You should ...
1 year, 2 months ago #3
oshima (OOO April 11 - 21)
lgtm with optional nit https://codereview.chromium.org/12088081/diff/7001/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc (right): https://codereview.chromium.org/12088081/diff/7001/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc#newcode141 chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:141: size_t min_displays = display_manager->HasInternalDisplay() ? ...
1 year, 2 months ago #4
Jun Mukai
https://codereview.chromium.org/12088081/diff/7001/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc (right): https://codereview.chromium.org/12088081/diff/7001/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc#newcode141 chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:141: size_t min_displays = display_manager->HasInternalDisplay() ? 2 : 1; On ...
1 year, 2 months ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12088081/5
1 year, 2 months ago #6
I haz the power (commit-bot)
1 year, 2 months ago #7
Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6