Issue 12088037: Revert 179302

Issue 12088037: Revert 179302 (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 10 months ago

Reviewers:
benwells

CC:
chromium-reviews, sadrul, akalin, ben+watch_chromium.org, tfarina, Raghu Simha, haitaol1, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 179302 Breaks linking on app_list_unittest on Linux: symbol lookup error: libcontent.so: undefined symbol: _ZN15MallocExtension32GetBytesAllocatedOnCurrentThreadEv > [win] Add signin support for the app launcher. > > This relands r178795, with the navigation to the sign in screen deferred until > the app list is shown and sign in is needed. > > TBR=sky@chromium.org, atwilson@chromium.org, rogerta@chromium.org, xiyuan@chromium.org > BUG=159733 > > Review URL: https://codereview.chromium.org/12095027 TBR=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179307

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -490 lines)			Patch
M	ash/shell/app_list.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_view_delegate.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_view_delegate.cc	View	3 chunks	+0 lines, -8 lines	0 comments	Download
D	chrome/browser/ui/app_list/chrome_signin_delegate.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/ui/app_list/chrome_signin_delegate.cc	View	1 chunk	+0 lines, -138 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	3 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_sync_starter.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_sync_starter.cc	View	3 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/app_list/app_list.gyp	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	ui/app_list/app_list_view_delegate.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
D	ui/app_list/signin_delegate.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	ui/app_list/signin_delegate.cc	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	ui/app_list/signin_delegate_observer.h	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	ui/app_list/views/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/app_list/views/app_list_main_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/app_list/views/app_list_main_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/app_list/views/app_list_view.h	View	4 chunks	+3 lines, -19 lines	0 comments	Download
M	ui/app_list/views/app_list_view.cc	View	6 chunks	+4 lines, -53 lines	0 comments	Download
M	ui/app_list/views/search_box_view.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	ui/app_list/views/signin_view.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	ui/app_list/views/signin_view.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages