Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 12095027: [win] Add signin support for the app launcher. (Closed)

Created:
7 years, 10 months ago by benwells
Modified:
7 years, 10 months ago
CC:
chromium-reviews, sadrul, akalin, ben+watch_chromium.org, tfarina, Raghu Simha, haitaol1, tim (not reviewing), sky, Andrew T Wilson (Slow), Roger Tawa OOO till Jul 10th, xiyuan
Visibility:
Public.

Description

[win] Add signin support for the app launcher. This relands r178795, with the navigation to the sign in screen deferred until the app list is shown and sign in is needed. TBR=sky@chromium.org, atwilson@chromium.org, rogerta@chromium.org, xiyuan@chromium.org BUG=159733 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179302

Patch Set 1 #

Patch Set 2 : Only go to signin once list is shown #

Patch Set 3 : Fix cros test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -31 lines) Patch
ash/shell/app_list.cc View 1 chunk +4 lines, -0 lines 0 comments Download
chrome/browser/ui/app_list/app_list_view_delegate.h View 3 chunks +3 lines, -0 lines 0 comments Download
chrome/browser/ui/app_list/app_list_view_delegate.cc View 3 chunks +8 lines, -0 lines 0 comments Download
chrome/browser/ui/app_list/chrome_signin_delegate.h View 1 chunk +48 lines, -0 lines 0 comments Download
chrome/browser/ui/app_list/chrome_signin_delegate.cc View 1 chunk +138 lines, -0 lines 0 comments Download
chrome/browser/ui/sync/one_click_signin_helper.cc View 3 chunks +10 lines, -9 lines 0 comments Download
chrome/browser/ui/sync/one_click_signin_sync_starter.h View 2 chunks +5 lines, -1 line 0 comments Download
chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 3 chunks +12 lines, -12 lines 0 comments Download
chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
ui/app_list/app_list.gyp View 3 chunks +7 lines, -0 lines 0 comments Download
ui/app_list/app_list_view_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
ui/app_list/signin_delegate.h View 1 chunk +43 lines, -0 lines 0 comments Download
ui/app_list/signin_delegate.cc View 1 chunk +27 lines, -0 lines 0 comments Download
ui/app_list/signin_delegate_observer.h View 1 chunk +24 lines, -0 lines 0 comments Download
ui/app_list/views/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
ui/app_list/views/app_list_main_view.h View 1 chunk +1 line, -1 line 0 comments Download
ui/app_list/views/app_list_main_view.cc View 1 chunk +1 line, -1 line 0 comments Download
ui/app_list/views/app_list_view.h View 1 4 chunks +19 lines, -3 lines 0 comments Download
ui/app_list/views/app_list_view.cc View 1 6 chunks +53 lines, -4 lines 0 comments Download
ui/app_list/views/search_box_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
ui/app_list/views/signin_view.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
ui/app_list/views/signin_view.cc View 1 2 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benwells
Hey koz, patch set 1 already has / had lgtms from all owners needed. Could ...
7 years, 10 months ago (2013-01-29 02:41:27 UTC) #1
benwells
7 years, 10 months ago (2013-01-29 02:44:56 UTC) #2
koz (OOO until 15th September)
lgtm
7 years, 10 months ago (2013-01-29 02:53:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/12095027/2001
7 years, 10 months ago (2013-01-29 03:50:58 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-01-29 04:14:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/12095027/11002
7 years, 10 months ago (2013-01-29 06:16:00 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-01-29 06:39:25 UTC) #7
Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698