Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 12088020: Fix bug in html element remove. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 8d8922b6761ab56719ddb60ca5b44ff9f0b035bf..a17ccc09ce8806cbfd7ef49fdd354e6588937942 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -8066,7 +8066,7 @@ class _ChildrenElementList implements List {
void remove(Object object) {
if (object is Element) {
Element element = object;
- if (identical(element.parentNode, this)) {
+ if (identical(element.parentNode, _element)) {
_element.$dom_removeChild(element);
}
}
@@ -13535,7 +13535,7 @@ abstract class DateTimeInputElement implements RangeInputElementBase {
factory DateTimeInputElement() => new InputElement(type: 'datetime');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
@@ -13560,7 +13560,7 @@ abstract class DateInputElement implements RangeInputElementBase {
factory DateInputElement() => new InputElement(type: 'date');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
@@ -13585,7 +13585,7 @@ abstract class MonthInputElement implements RangeInputElementBase {
factory MonthInputElement() => new InputElement(type: 'month');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
@@ -13610,7 +13610,7 @@ abstract class WeekInputElement implements RangeInputElementBase {
factory WeekInputElement() => new InputElement(type: 'week');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
@@ -13635,7 +13635,7 @@ abstract class TimeInputElement implements RangeInputElementBase {
factory TimeInputElement() => new InputElement(type: 'time');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
@@ -25604,7 +25604,7 @@ class Window extends EventTarget implements WindowBase native "@*DOMWindow" {
if ($this.requestAnimationFrame && $this.cancelAnimationFrame) return;
$this.requestAnimationFrame = function(callback) {
return window.setTimeout(function() {
- callback(Date.now());
+ callback(DateTime.now());
}, 16 /* 16ms ~= 60fps */);
};
$this.cancelAnimationFrame = function(id) { clearTimeout(id); }
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698