Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 12088020: Fix bug in html element remove. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 383a8e44c168099e978f749a8066e39fe0f2277e..ff1dcb34d9ce0cf2e20c2688918f96891e0195a2 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -8844,7 +8844,7 @@ class _ChildrenElementList implements List {
void remove(Object object) {
if (object is Element) {
Element element = object;
- if (identical(element.parentNode, this)) {
+ if (identical(element.parentNode, _element)) {
_element.$dom_removeChild(element);
}
}
@@ -14726,7 +14726,7 @@ abstract class DateTimeInputElement implements RangeInputElementBase {
factory DateTimeInputElement() => new InputElement(type: 'datetime');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
@@ -14751,7 +14751,7 @@ abstract class DateInputElement implements RangeInputElementBase {
factory DateInputElement() => new InputElement(type: 'date');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
@@ -14776,7 +14776,7 @@ abstract class MonthInputElement implements RangeInputElementBase {
factory MonthInputElement() => new InputElement(type: 'month');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
@@ -14801,7 +14801,7 @@ abstract class WeekInputElement implements RangeInputElementBase {
factory WeekInputElement() => new InputElement(type: 'week');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
@@ -14826,7 +14826,7 @@ abstract class TimeInputElement implements RangeInputElementBase {
factory TimeInputElement() => new InputElement(type: 'time');
@DomName('HTMLInputElement.valueAsDate')
- Date valueAsDate;
+ DateTime valueAsDate;
@DomName('HTMLInputElement.readOnly')
bool readOnly;
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698