Add ability for EventGenerator to generate Scroll events asynchronously

Add ability for EventGenerator to generate Scroll events asynchronously

This has been split out from https://codereview.chromium.org/11881042

BUG=124830
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179348

[sadrul, 2013-01-28 17:51:17]

LGTM

https://codereview.chromium.org/12088015/diff/1/ui/aura/test/event_generator.h
File ui/aura/test/event_generator.h (right):

https://codereview.chromium.org/12088015/diff/1/ui/aura/test/event_generator....
ui/aura/test/event_generator.h:85: void set_post_events(bool post_events) {
post_events_ = post_events; }
Perhaps 'async' would be clearer than 'post'

[sky, 2013-01-28 19:10:55]

https://codereview.chromium.org/12088015/diff/1/chrome/browser/ui/views/autof...
File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right):

https://codereview.chromium.org/12088015/diff/1/chrome/browser/ui/views/autof...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:169: ui::MouseEvent
event_copy(event);
Is there a reason for doing these changes? Seems like less code with the
ProxyEvent function.

https://codereview.chromium.org/12088015/diff/1/ui/aura/test/event_generator.h
File ui/aura/test/event_generator.h (right):

https://codereview.chromium.org/12088015/diff/1/ui/aura/test/event_generator....
ui/aura/test/event_generator.h:85: void set_post_events(bool post_events) {
post_events_ = post_events; }
On 2013/01/28 17:51:18, sadrul wrote:
> Perhaps 'async' would be clearer than 'post'

+1 here. I was about to write the same comment.

[DaveMoore, 2013-01-28 23:25:20]

https://codereview.chromium.org/12088015/diff/1/chrome/browser/ui/views/autof...
File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right):

https://codereview.chromium.org/12088015/diff/1/chrome/browser/ui/views/autof...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:169: ui::MouseEvent
event_copy(event);
When I made the MouseEvent() constructor explicit this became a problem. I
deleted it and LocatedEvent's as well, which causes them to have implicit
constructors and the code works again
On 2013/01/28 19:10:55, sky wrote:
> Is there a reason for doing these changes? Seems like less code with the
> ProxyEvent function.

https://codereview.chromium.org/12088015/diff/1/ui/aura/test/event_generator.h
File ui/aura/test/event_generator.h (right):

https://codereview.chromium.org/12088015/diff/1/ui/aura/test/event_generator....
ui/aura/test/event_generator.h:85: void set_post_events(bool post_events) {
post_events_ = post_events; }
On 2013/01/28 17:51:18, sadrul wrote:
> Perhaps 'async' would be clearer than 'post'

Done.

[sky, 2013-01-29 15:42:56]

LGTM

https://codereview.chromium.org/12088015/diff/10004/ui/aura/test/event_genera...
File ui/aura/test/event_generator.cc (right):

https://codereview.chromium.org/12088015/diff/10004/ui/aura/test/event_genera...
ui/aura/test/event_generator.cc:111: }
delete events in pending_events_.