Add ability for EventGenerator to generate Scroll events asynchronously

chrome/browser/ui/views/autofill/autofill_dialog_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
 
 #include <utility>
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/wallet/wallet_service_url.h"
@@ skipping 148 matching lines @@
     set_background(NULL);
 }
 
 void AutofillDialogViews::SectionContainer::OnMouseEntered(
     const ui::MouseEvent& event) {
   if (!forward_mouse_events_)
     return;
 
   // TODO(estade): use the correct color.
   set_background(views::Background::CreateSolidBackground(SK_ColorLTGRAY));
-  proxy_button_->OnMouseEntered(ProxyEvent(event));
+  ui::MouseEvent event_copy(event);

[sky, 2013/01/28 19:10:55]

Is there a reason for doing these changes? Seems like less code with the
ProxyEvent function.

[DaveMoore, 2013/01/28 23:25:20]

When I made the MouseEvent() constructor explicit this became a problem. I
deleted it and LocatedEvent's as well, which causes them to have implicit
constructors and the code works again
On 2013/01/28 19:10:55, sky wrote:

+  event_copy.set_location(gfx::Point());
+  proxy_button_->OnMouseEntered(event_copy);
   SchedulePaint();
 }
 
 void AutofillDialogViews::SectionContainer::OnMouseExited(
     const ui::MouseEvent& event) {
   if (!forward_mouse_events_)
     return;
 
   set_background(NULL);
-  proxy_button_->OnMouseExited(ProxyEvent(event));
+  ui::MouseEvent event_copy(event);
+  event_copy.set_location(gfx::Point());
+  proxy_button_->OnMouseExited(event_copy);
   SchedulePaint();
 }
 
 bool AutofillDialogViews::SectionContainer::OnMousePressed(
     const ui::MouseEvent& event) {
   if (!forward_mouse_events_)
     return false;
 
-  return proxy_button_->OnMousePressed(ProxyEvent(event));
+  ui::MouseEvent event_copy(event);
+  event_copy.set_location(gfx::Point());
+  return proxy_button_->OnMousePressed(event_copy);
 }
 
 void AutofillDialogViews::SectionContainer::OnMouseReleased(
     const ui::MouseEvent& event) {
   if (!forward_mouse_events_)
     return;
 
-  proxy_button_->OnMouseReleased(ProxyEvent(event));
-}
-
-// static
-ui::MouseEvent AutofillDialogViews::SectionContainer::ProxyEvent(
-    const ui::MouseEvent& event) {
-  ui::MouseEvent event_copy = event;
+  ui::MouseEvent event_copy(event);
   event_copy.set_location(gfx::Point());
-  return event_copy;
+  proxy_button_->OnMouseReleased(event_copy);
 }
 
 // AutofilDialogViews::SuggestionView ------------------------------------------
 
 AutofillDialogViews::SuggestionView::SuggestionView(
     const string16& edit_label,
     views::LinkListener* edit_listener)
     : label_(new views::Label()),
       icon_(new views::ImageView()),
       label_container_(new views::View()) {
@@ skipping 620 matching lines @@
 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
     : section(section),
       container(NULL),
       manual_input(NULL),
       suggested_info(NULL),
       suggested_button(NULL) {}
 
 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
 
 }  // namespace autofill