Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1208763003: Don't suppress nanobench output table in verbose mode (Closed)

Created:
5 years, 6 months ago by Chris Dalton
Modified:
5 years, 6 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload_timesamples
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't suppress nanobench output table in verbose mode Changes verbose mode to print both the table and the individual sample values. No need to hold back information in verbose mode. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2c56ba5cde25a5cdbeca2afd660b497b428e8f07

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : bin/compare #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M bench/nanobench.cpp View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M bin/compare View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Chris Dalton
5 years, 6 months ago (2015-06-25 03:52:20 UTC) #2
mtklein
On 2015/06/25 03:52:20, Chris Dalton wrote: Think you can hack up bin/compare so that it ...
5 years, 6 months ago (2015-06-25 11:58:33 UTC) #3
Chris Dalton
On 2015/06/25 11:58:33, mtklein wrote: > On 2015/06/25 03:52:20, Chris Dalton wrote: > > Think ...
5 years, 6 months ago (2015-06-25 21:43:38 UTC) #4
mtklein
lgtm
5 years, 6 months ago (2015-06-26 18:53:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208763003/40001
5 years, 6 months ago (2015-06-26 18:53:12 UTC) #7
commit-bot: I haz the power
The author cdalton@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-26 18:53:14 UTC) #8
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-26 18:54:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208763003/60001
5 years, 6 months ago (2015-06-26 20:27:15 UTC) #13
commit-bot: I haz the power
The author cdalton@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-26 20:27:17 UTC) #14
commit-bot: I haz the power
The author cdalton@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-26 20:31:26 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 20:32:57 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/2c56ba5cde25a5cdbeca2afd660b497b428e8f07

Powered by Google App Engine
This is Rietveld 408576698