Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 12087120: Revert 179987 (Closed)

Created:
7 years, 10 months ago by dmichael (off chromium)
Modified:
7 years, 10 months ago
Reviewers:
teravest
CC:
chromium-reviews, jam, sail+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, markusheintz_, erikwright+watch_chromium.org
Visibility:
Public.

Description

Revert 179987 Caused memory leak: Leak_DefinitelyLost 4,196 (1,600 direct, 2,596 indirect) bytes in 4 blocks are definitely lost in loss record 608 of 639 operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1140) IPC::SyncChannel::SyncChannel(IPC::ChannelHandle const&, IPC::Channel::Mode, IPC::Listener*, base::SingleThreadTaskRunner*, bool, base::WaitableEvent*) (ipc/ipc_sync_channel.cc:410) (anonymous namespace)::RestrictedDispatchPipeWorker::Run() (ipc/ipc_sync_channel_unittest.cc:1636) (anonymous namespace)::Worker::OnStart() (ipc/ipc_sync_channel_unittest.cc:176) Suppression (error hash=#2A77226DFEFF6041#): For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZN3IPC11SyncChannelC1ERKNS_13ChannelHandleENS_7Channel4ModeEPNS_8ListenerEPN4base22SingleThreadTaskRunnerEbPNS8_13WaitableEventE fun:_ZN12_GLOBAL__N_128RestrictedDispatchPipeWorker3RunEv fun:_ZN12_GLOBAL__N_16Worker7OnStartEv } 15:02:51 memcheck_a http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/22101 > Refactor: Simplify WaitableEventWatcher. > > This change uses a callback instead of a delegate for specifying what > should be called when a WaitableEvent occurs. > > This simplifies the class and gets rid of a workaround internal to the > class to prevent name collision on "Delegate" inner classes. > > Tested (on linux and windows): > ninja -C out/Debug chrome > out/Debug/base_unittests --gtest_filter=*WaitableEventWatcherTest* > > BUG= > > > Review URL: https://chromiumcodereview.appspot.com/11953112 TBR=teravest@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -111 lines) Patch
M base/synchronization/waitable_event_watcher.h View 3 chunks +70 lines, -20 lines 0 comments Download
M base/synchronization/waitable_event_watcher_posix.cc View 7 chunks +12 lines, -13 lines 0 comments Download
M base/synchronization/waitable_event_watcher_unittest.cc View 7 chunks +20 lines, -18 lines 0 comments Download
M base/synchronization/waitable_event_watcher_win.cc View 2 chunks +23 lines, -11 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/plugin_data_remover_impl_browsertest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M content/browser/plugin_service_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ipc/ipc_sync_channel.h View 6 chunks +8 lines, -10 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 6 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmichael (off chromium)
7 years, 10 months ago (2013-01-31 23:14:08 UTC) #1
teravest
7 years, 10 months ago (2013-01-31 23:15:21 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698