Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 12087054: Revert 140611 (Closed)

Created:
7 years, 10 months ago by karen
Modified:
7 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1397/
Visibility:
Public.

Description

Revert 140611 > [V8] Reduce usage of deprecatedV8String() and deprecatedV8Integer() > https://bugs.webkit.org/show_bug.cgi?id=107674 > > Reviewed by Adam Barth. > > No tests. No change in behavior. > > * bindings/v8/JavaScriptCallFrame.cpp: > (WebCore::JavaScriptCallFrame::evaluate): > * bindings/v8/NPV8Object.cpp: > (_NPN_Enumerate): > * bindings/v8/PageScriptDebugServer.cpp: > (WebCore::PageScriptDebugServer::addListener): > * bindings/v8/ScriptController.cpp: > (WebCore::ScriptController::bindToWindowObject): > (WebCore::ScriptController::disableEval): > * bindings/v8/ScriptDebugServer.cpp: > (WebCore::ScriptDebugServer::setBreakpoint): > (WebCore::ScriptDebugServer::removeBreakpoint): > (WebCore::ScriptDebugServer::setScriptSource): > (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled): > (WebCore::ScriptDebugServer::compileScript): > * bindings/v8/ScriptFunctionCall.cpp: > (WebCore::ScriptCallArgumentHandler::appendArgument): > (WebCore::ScriptFunctionCall::call): > (WebCore::ScriptFunctionCall::construct): > * bindings/v8/ScriptProfiler.cpp: > (WebCore::ScriptProfiler::start): > (WebCore::ScriptProfiler::stop): > * bindings/v8/V8DOMWindowShell.cpp: > (WebCore::V8DOMWindowShell::initializeIfNeeded): > (WebCore::V8DOMWindowShell::namedItemAdded): > (WebCore::V8DOMWindowShell::namedItemRemoved): > * bindings/v8/V8LazyEventListener.cpp: > (WebCore::V8LazyEventListener::prepareListenerObject): > * bindings/v8/V8MutationCallback.cpp: > (WebCore::V8MutationCallback::handleEvent): > * bindings/v8/WorkerScriptController.cpp: > (WebCore::WorkerScriptController::evaluate): > * bindings/v8/WorkerScriptDebugServer.cpp: > (WebCore::WorkerScriptDebugServer::addListener): > * bindings/v8/custom/V8InjectedScriptManager.cpp: > (WebCore::InjectedScriptManager::createInjectedScript): > TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M Source/WebCore/bindings/v8/JavaScriptCallFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/bindings/v8/NPV8Object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/bindings/v8/PageScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/bindings/v8/ScriptController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptDebugServer.cpp View 5 chunks +10 lines, -11 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptFunctionCall.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptProfiler.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/bindings/v8/V8DOMWindowShell.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/bindings/v8/V8LazyEventListener.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/WebCore/bindings/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/bindings/v8/WorkerScriptController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/bindings/v8/WorkerScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/bindings/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
karen
7 years, 10 months ago (2013-01-29 16:53:31 UTC) #1
haraken
7 years, 10 months ago (2013-01-29 23:48:17 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698