Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: Source/WebCore/bindings/v8/V8LazyEventListener.cpp

Issue 12087054: Revert 140611 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1397/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/bindings/v8/V8DOMWindowShell.cpp ('k') | Source/WebCore/bindings/v8/V8MutationCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/bindings/v8/V8LazyEventListener.cpp
===================================================================
--- Source/WebCore/bindings/v8/V8LazyEventListener.cpp (revision 141118)
+++ Source/WebCore/bindings/v8/V8LazyEventListener.cpp (working copy)
@@ -155,7 +155,7 @@
"};"
"}}}})";
- v8::Handle<v8::String> codeExternalString = v8String(code, v8Context->GetIsolate());
+ v8::Handle<v8::String> codeExternalString = deprecatedV8String(code);
v8::Handle<v8::Script> script = ScriptSourceCode::compileScript(codeExternalString, m_sourceURL, m_position);
if (script.IsEmpty())
@@ -185,11 +185,11 @@
v8::Local<v8::Object> thisObject = v8::Object::New();
if (thisObject.IsEmpty())
return;
- if (!thisObject->ForceSet(v8Integer(0, v8Context->GetIsolate()), nodeWrapper))
+ if (!thisObject->ForceSet(deprecatedV8Integer(0), nodeWrapper))
return;
- if (!thisObject->ForceSet(v8Integer(1, v8Context->GetIsolate()), formWrapper))
+ if (!thisObject->ForceSet(deprecatedV8Integer(1), formWrapper))
return;
- if (!thisObject->ForceSet(v8Integer(2, v8Context->GetIsolate()), documentWrapper))
+ if (!thisObject->ForceSet(deprecatedV8Integer(2), documentWrapper))
return;
// FIXME: Remove this code when we stop doing the 'with' hack above.
@@ -220,11 +220,11 @@
toStringFunction = toStringTemplate->GetFunction();
if (!toStringFunction.IsEmpty()) {
String toStringString = "function " + m_functionName + "(" + m_eventParameterName + ") {\n " + m_code + "\n}";
- wrappedFunction->SetHiddenValue(V8HiddenPropertyName::toStringString(), v8String(toStringString, v8Context->GetIsolate()));
+ wrappedFunction->SetHiddenValue(V8HiddenPropertyName::toStringString(), deprecatedV8String(toStringString));
wrappedFunction->Set(v8::String::NewSymbol("toString"), toStringFunction);
}
- wrappedFunction->SetName(v8String(m_functionName, v8Context->GetIsolate()));
+ wrappedFunction->SetName(deprecatedV8String(m_functionName));
// FIXME: Remove the following comment-outs.
// See https://bugs.webkit.org/show_bug.cgi?id=85152 for more details.
« no previous file with comments | « Source/WebCore/bindings/v8/V8DOMWindowShell.cpp ('k') | Source/WebCore/bindings/v8/V8MutationCallback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698