Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 12087013: Libvpx roll to r179054 (Closed)

Created:
7 years, 11 months ago by fgalligan1
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Libvpx roll to r179054 From r178966 This roll adds support for building libvpx under 64bit Windows as well as fixing build warnings on Windows. See below CLs for the code changes: https://codereview.chromium.org/12084013 https://codereview.chromium.org/12077018 BUG=170672, 171387 TEST=libvpx should build under x64. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179697

Patch Set 1 #

Total comments: 1

Patch Set 2 : Libvpx roll to r179478 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
wolenetz
https://codereview.chromium.org/12087013/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/12087013/diff/1/DEPS#newcode23 DEPS:23: "libvpx_revision": "179054", I still found warnings when I patched ...
7 years, 10 months ago (2013-01-28 21:59:30 UTC) #1
fgalligan1
On 2013/01/28 21:59:30, wolenetz wrote: > https://codereview.chromium.org/12087013/diff/1/DEPS > File DEPS (right): > > https://codereview.chromium.org/12087013/diff/1/DEPS#newcode23 > ...
7 years, 10 months ago (2013-01-29 01:04:12 UTC) #2
jschuh
lgtm
7 years, 10 months ago (2013-01-29 02:15:15 UTC) #3
wolenetz
On 2013/01/29 01:04:12, fgalligan1 wrote: > On 2013/01/28 21:59:30, wolenetz wrote: > > https://codereview.chromium.org/12087013/diff/1/DEPS > ...
7 years, 10 months ago (2013-01-29 18:28:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgalligan@chromium.org/12087013/12002
7 years, 10 months ago (2013-01-30 18:51:10 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-01-30 21:04:47 UTC) #6
Message was sent while issue was closed.
Change committed as 179697

Powered by Google App Engine
This is Rietveld 408576698