Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: content/browser/web_contents/web_contents_view_guest.cc

Issue 12086095: Fixed drag and drop into and out of Browser Plugin. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Drag and drop enabled for linux only Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_guest.cc
diff --git a/content/browser/web_contents/web_contents_view_guest.cc b/content/browser/web_contents/web_contents_view_guest.cc
index 088ebfdac3745ce22d6fe330b6b8521d22ff94fd..ef89ec6b06a819447906597bbe571ace4fb377b4 100644
--- a/content/browser/web_contents/web_contents_view_guest.cc
+++ b/content/browser/web_contents/web_contents_view_guest.cc
@@ -11,6 +11,7 @@
#include "content/browser/renderer_host/render_widget_host_view_guest.h"
#include "content/browser/web_contents/interstitial_page_impl.h"
#include "content/browser/web_contents/web_contents_impl.h"
+#include "content/common/drag_messages.h"
#include "content/public/browser/web_contents_delegate.h"
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/point.h"
@@ -155,7 +156,14 @@ WebDropData* WebContentsViewGuest::GetDropData() const {
}
void WebContentsViewGuest::UpdateDragCursor(WebDragOperation operation) {
- NOTIMPLEMENTED();
+ RenderViewHostImpl* embedder_render_view_host =
+ static_cast<RenderViewHostImpl*>(
+ guest_->embedder_web_contents()->GetRenderViewHost());
+ CHECK(embedder_render_view_host);
+ RenderViewHostDelegateView* view =
+ embedder_render_view_host->GetDelegate()->GetDelegateView();
+ if (view)
+ view->UpdateDragCursor(operation);
}
void WebContentsViewGuest::GotFocus() {
@@ -187,7 +195,14 @@ void WebContentsViewGuest::StartDragging(
const gfx::ImageSkia& image,
const gfx::Vector2d& image_offset,
const DragEventSourceInfo& event_info) {
- NOTIMPLEMENTED();
+ RenderViewHostImpl* embedder_render_view_host =
Fady Samuel 2013/04/09 20:49:12 wrong spacing.
mthiesse 2013/04/18 18:02:03 Done.
+ static_cast<RenderViewHostImpl*>(
+ guest_->embedder_web_contents()->GetRenderViewHost());
+ CHECK(embedder_render_view_host);
+ RenderViewHostDelegateView* view =
+ embedder_render_view_host->GetDelegate()->GetDelegateView();
+ if (view)
+ view->StartDragging(drop_data, ops, image, image_offset, event_info);
dcheng 2013/04/09 20:59:12 Make sure you call SystemDragEnded() if there's no
mthiesse 2013/04/18 18:02:03 Done.
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698