content/browser/web_contents/web_drag_source_gtk.cc - Issue 12086095: Fixed drag and drop into and out of Browser Plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_drag_source_gtk.cc

Issue 12086095: Fixed drag and drop into and out of Browser Plugin. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Drag and drop enabled for linux only Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_drag_source_gtk.cc

diff --git a/content/browser/web_contents/web_drag_source_gtk.cc b/content/browser/web_contents/web_drag_source_gtk.cc

index c3a786f9a2dd8de118d54b1e6abba9376314e202..cbe35a5bb9fd07992dd07103432dfa6fda16f9f7 100644

--- a/content/browser/web_contents/web_drag_source_gtk.cc

+++ b/content/browser/web_contents/web_drag_source_gtk.cc

@@ -165,7 +165,7 @@ void WebDragSourceGtk::DidProcessEvent(GdkEvent* event) {

gfx::Point client = ui::ClientPoint(GetContentNativeView());

if (GetRenderViewHost()) {

Fady Samuel 2013/04/09 20:49:12 This guard seems weird...if (web_contents_) seems

mthiesse 2013/04/18 18:02:03 Done.

- GetRenderViewHost()->DragSourceMovedTo(

+ web_contents_->DragSourceMovedTo(

client.x(), client.y(),

static_cast<int>(event_motion->x_root),

static_cast<int>(event_motion->y_root));

@@ -301,7 +301,7 @@ gboolean WebDragSourceGtk::OnDragFailed(GtkWidget* sender,

gfx::Point client = ui::ClientPoint(GetContentNativeView());

if (GetRenderViewHost()) {

Fady Samuel 2013/04/09 20:49:12 This guard seems weird...if (web_contents_) seems

mthiesse 2013/04/18 18:02:03 Done.

- GetRenderViewHost()->DragSourceEndedAt(

+ web_contents_->DragSourceEndedAt(

client.x(), client.y(), root.x(), root.y(),

WebDragOperationNone);

}

@@ -373,7 +373,7 @@ void WebDragSourceGtk::OnDragEnd(GtkWidget* sender,

gfx::Point client = ui::ClientPoint(GetContentNativeView());

if (GetRenderViewHost()) {

Fady Samuel 2013/04/09 20:49:12 This guard seems weird...if (web_contents_) seems

mthiesse 2013/04/18 18:02:03 Done.

- GetRenderViewHost()->DragSourceEndedAt(

+ web_contents_->DragSourceEndedAt(

client.x(), client.y(), root.x(), root.y(),

GdkDragActionToWebDragOp(drag_context->action));

}