Issue 12086041: Merge 140928

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12086041: Merge 140928 (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/

Visibility:
Public.

More Reviews

Description

Merge 140928 > [chromium] add missing plumbing for Notification.requestPermission > https://bugs.webkit.org/show_bug.cgi?id=108012 > > Reviewed by Adam Barth. > > Source/WebKit/chromium: > > * src/NotificationPresenterImpl.cpp: > (WebKit): > (WebKit::VoidCallbackClient::VoidCallbackClient): > (NotificationPermissionCallbackClient): > (WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient): > (WebKit::NotificationPermissionCallbackClient::permissionRequestComplete): > (WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient): > (WebKit::NotificationPresenterImpl::requestPermission): > * src/NotificationPresenterImpl.h: > (NotificationPresenterImpl): > > LayoutTests: > > * fast/notifications/notifications-constructor-request-permission-expected.txt: Added. > * fast/notifications/notifications-constructor-request-permission.html: Added. > TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141076

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -0 lines)			Patch
A +	LayoutTests/fast/notifications/notifications-constructor-request-permission.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebKit/chromium/src/NotificationPresenterImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebKit/chromium/src/NotificationPresenterImpl.cpp	View	3 chunks	+38 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages