Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: chrome/browser/extensions/app_notify_channel_setup.h

Issue 12086018: GTTF: Add missing virtual destructors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: protected -> public Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_notify_channel_setup.h
diff --git a/chrome/browser/extensions/app_notify_channel_setup.h b/chrome/browser/extensions/app_notify_channel_setup.h
index a43e08b3cf3a0ac22c6ecded36a9c9b77f575882..a98b8401e31b57177cd5b332c74ac1781dfc604a 100644
--- a/chrome/browser/extensions/app_notify_channel_setup.h
+++ b/chrome/browser/extensions/app_notify_channel_setup.h
@@ -51,6 +51,8 @@ class AppNotifyChannelSetup
class Delegate {
public:
+ virtual ~Delegate() { }
+
// If successful, |channel_id| will be non-empty. On failure, |channel_id|
// will be empty and |error| will contain an error to report to the JS
// callback.
@@ -68,6 +70,9 @@ class AppNotifyChannelSetup
const AppNotifyChannelSetup* setup,
std::string* result_channel_id,
AppNotifyChannelSetup::SetupError* result_error) = 0;
+
+ protected:
+ virtual ~InterceptorForTests() { }
jar (doing other things) 2013/02/01 03:41:07 nit: IMO, better is public, unless you have a STRO
Paweł Hajdan Jr. 2013/02/01 10:12:43 Done, sorry I just forgot to change it to public.
};
static void SetInterceptorForTests(InterceptorForTests* interceptor);

Powered by Google App Engine
This is Rietveld 408576698