GTTF: Add missing virtual destructors.

chrome/browser/extensions/app_notify_channel_setup.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_APP_NOTIFY_CHANNEL_SETUP_H_
 #define CHROME_BROWSER_EXTENSIONS_APP_NOTIFY_CHANNEL_SETUP_H_
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
@@ skipping 33 matching lines @@
     AUTH_ERROR,
     INTERNAL_ERROR,
     USER_CANCELLED,
 
     // This is used for histograms, and should always be the last value.
     SETUP_ERROR_BOUNDARY
   };
 
   class Delegate {
    public:
+    virtual ~Delegate() { }
+
     // If successful, |channel_id| will be non-empty. On failure, |channel_id|
     // will be empty and |error| will contain an error to report to the JS
     // callback.
     virtual void AppNotifyChannelSetupComplete(
         const std::string& channel_id,
         const std::string& error,
         const AppNotifyChannelSetup* setup) = 0;
   };
 
   // For tests, we allow intercepting the request to setup the channel and
   // forcing the return of a certain result to the delegate.
   class InterceptorForTests {
    public:
     virtual void DoIntercept(
         const AppNotifyChannelSetup* setup,
         std::string* result_channel_id,
         AppNotifyChannelSetup::SetupError* result_error) = 0;
+
+   protected:
+    virtual ~InterceptorForTests() { }

[jar (doing other things), 2013/02/01 03:41:07]

nit: IMO, better is public, unless you have a STRONG reason, so as to not change
existing semantics.

[Paweł Hajdan Jr., 2013/02/01 10:12:43]

Done, sorry I just forgot to change it to public.

   };
   static void SetInterceptorForTests(InterceptorForTests* interceptor);
 
   // Ownership of |ui| is transferred to this object.
   AppNotifyChannelSetup(Profile* profile,
                         const std::string& extension_id,
                         const std::string& client_id,
                         const GURL& requestor_url,
                         int return_route_id,
                         int callback_id,
@@ skipping 90 matching lines @@
   // infinite loop of trying to generate access token, if that fails, try
   // to login the user and generate access token, etc.
   bool oauth2_access_token_failure_;
 
   DISALLOW_COPY_AND_ASSIGN(AppNotifyChannelSetup);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_APP_NOTIFY_CHANNEL_SETUP_H_