Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2643)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 1208593003: DevTools: Make FilmStripView support custom status text. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/components_lazy/FilmStripView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index 563489b0e7f4a748e89d74fccd9f50b328cb64a4..a533ba832d2d4284dff23284e0404f6f703c1563 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -287,7 +287,7 @@ WebInspector.NetworkPanel.prototype = {
this._overviewPane.reset();
this._networkLogView.reset();
if (this._filmStripView)
- this._filmStripView.reset();
+ this._resetFilmStripView();
},
/**
@@ -338,6 +338,7 @@ WebInspector.NetworkPanel.prototype = {
this._filmStripView.addEventListener(WebInspector.FilmStripView.Events.FrameSelected, this._onFilmFrameSelected, this);
this._filmStripView.addEventListener(WebInspector.FilmStripView.Events.FrameEnter, this._onFilmFrameEnter, this);
this._filmStripView.addEventListener(WebInspector.FilmStripView.Events.FrameExit, this._onFilmFrameExit, this);
+ this._resetFilmStripView();
}
if (!toggled && this._filmStripRecorder) {
@@ -347,6 +348,12 @@ WebInspector.NetworkPanel.prototype = {
}
},
+ _resetFilmStripView: function()
+ {
+ this._filmStripView.reset();
+ this._filmStripView.setStatusText(WebInspector.UIString("No frames recorded. Reload page to start recording."));
+ },
+
/**
* @return {boolean}
*/
@@ -769,7 +776,8 @@ WebInspector.NetworkPanel.FilmStripRecorder.prototype = {
this._target = WebInspector.targetManager.mainTarget();
this._tracingModel = new WebInspector.TracingModel(new WebInspector.TempFileBackingStorage("tracing"));
this._target.tracingManager.start(this, "-*,disabled-by-default-devtools.screenshot", "");
- this._filmStripView.setRecording();
+ this._filmStripView.reset();
+ this._filmStripView.setStatusText(WebInspector.UIString("Recording frames..."));
},
/**
@@ -791,6 +799,6 @@ WebInspector.NetworkPanel.FilmStripRecorder.prototype = {
this._target.tracingManager.stop();
this._target = null;
this._callback = callback;
- this._filmStripView.setFetching();
+ this._filmStripView.setStatusText(WebInspector.UIString("Fetching frames..."));
}
}
« no previous file with comments | « Source/devtools/front_end/components_lazy/FilmStripView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698