Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: Source/devtools/front_end/components_lazy/FilmStripView.js

Issue 1208593003: DevTools: Make FilmStripView support custom status text. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/components_lazy/FilmStripView.js
diff --git a/Source/devtools/front_end/components_lazy/FilmStripView.js b/Source/devtools/front_end/components_lazy/FilmStripView.js
index ca1c8b5ae0c9ae05c7744ec36c6608a954306dcf..bc9bfa273915b1fa3c604b0bbfb4fc0d21bf038b 100644
--- a/Source/devtools/front_end/components_lazy/FilmStripView.js
+++ b/Source/devtools/front_end/components_lazy/FilmStripView.js
@@ -11,6 +11,7 @@ WebInspector.FilmStripView = function()
WebInspector.HBox.call(this, true);
this.registerRequiredCSS("components_lazy/filmStripView.css");
this.contentElement.classList.add("film-strip-view");
+ this._statusLabel = this.contentElement.createChild("div", "label");
this.reset();
this.setMode(WebInspector.FilmStripView.Modes.TimeBased);
}
@@ -111,7 +112,6 @@ WebInspector.FilmStripView.prototype = {
return;
this.contentElement.removeChildren();
- this._statusLabel.remove();
if (this._mode === WebInspector.FilmStripView.Modes.FrameBased) {
Promise.all(frames.map(this.createFrameElement.bind(this))).spread(this.contentElement.appendChildren.bind(this.contentElement));
@@ -181,19 +181,15 @@ WebInspector.FilmStripView.prototype = {
{
this._zeroTime = 0;
this.contentElement.removeChildren();
- this._statusLabel = this.contentElement.createChild("div", "label");
- this._statusLabel.textContent = WebInspector.UIString("No frames recorded. Reload page to start recording.");
+ this.contentElement.appendChild(this._statusLabel);
},
- setRecording: function()
- {
- this.reset();
- this._statusLabel.textContent = WebInspector.UIString("Recording frames...");
- },
-
- setFetching: function()
+ /**
+ * @param {string} text
+ */
+ setStatusText: function(text)
{
- this._statusLabel.textContent = WebInspector.UIString("Fetching frames...");
+ this._statusLabel.textContent = text;
},
__proto__: WebInspector.HBox.prototype
« no previous file with comments | « no previous file | Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698