Issue 12084093: Merge 141009

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12084093: Merge 141009 (Closed)

Created:
7 years, 10 months ago by Julien - ping for review

Modified:
7 years, 10 months ago

Reviewers:
jchaffraix

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/

Visibility:
Public.

More Reviews

Description

Merge 141009 > Crash inside RenderBlock::layoutRunsAndFloatsInRange in the widow code > https://bugs.webkit.org/show_bug.cgi?id=108084 > > Reviewed by Dean Jackson. > > This is a blind fix based on the code and Chromium's stack-traces. > > Unfortunately no new test as I couldn't get a local reproduction. > > * rendering/RenderBlockLineLayout.cpp: > (WebCore::RenderBlock::layoutRunsAndFloatsInRange): > Added a missing NULL-check: the previous 'while' finish if |lineBox| > is NULL and we don't want to crash in this case. > TBR=jchaffraix@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141460

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/WebCore/rendering/RenderBlockLineLayout.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages