Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 12084093: Merge 141009 (Closed)

Created:
8 years, 1 month ago by Julien - ping for review
Modified:
8 years, 1 month ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 141009 > Crash inside RenderBlock::layoutRunsAndFloatsInRange in the widow code > https://bugs.webkit.org/show_bug.cgi?id=108084 > > Reviewed by Dean Jackson. > > This is a blind fix based on the code and Chromium's stack-traces. > > Unfortunately no new test as I couldn't get a local reproduction. > > * rendering/RenderBlockLineLayout.cpp: > (WebCore::RenderBlock::layoutRunsAndFloatsInRange): > Added a missing NULL-check: the previous 'while' finish if |lineBox| > is NULL and we don't want to crash in this case. > TBR=jchaffraix@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/WebCore/rendering/RenderBlockLineLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
8 years, 1 month ago (2013-01-31 20:00:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698