Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/common/extensions/manifest_url_handler.h

Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tts, TODO Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_url_handler.h
diff --git a/chrome/common/extensions/manifest_url_handler.h b/chrome/common/extensions/manifest_url_handler.h
index 1492dbddd4914e3bf6e6bb9ec0b7e201bd758638..249542b182d48d2ffb175a3bf7df4efb7873bc8f 100644
--- a/chrome/common/extensions/manifest_url_handler.h
+++ b/chrome/common/extensions/manifest_url_handler.h
@@ -59,9 +59,7 @@ class DevToolsPageHandler : public ManifestHandler {
DevToolsPageHandler();
virtual ~DevToolsPageHandler();
- virtual bool Parse(const base::Value* value,
- Extension* extension,
- string16* error) OVERRIDE;
+ virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
};
// Parses the "homepage_url" manifest key.
@@ -70,9 +68,7 @@ class HomepageURLHandler : public ManifestHandler {
HomepageURLHandler();
virtual ~HomepageURLHandler();
- virtual bool Parse(const base::Value* value,
- Extension* extension,
- string16* error) OVERRIDE;
+ virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
};
// Parses the "update_url" manifest key.
@@ -81,9 +77,7 @@ class UpdateURLHandler : public ManifestHandler {
UpdateURLHandler();
virtual ~UpdateURLHandler();
- virtual bool Parse(const base::Value* value,
- Extension* extension,
- string16* error) OVERRIDE;
+ virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
};
// Parses the "options_page" manifest key.
@@ -92,9 +86,7 @@ class OptionsPageHandler : public ManifestHandler {
OptionsPageHandler();
virtual ~OptionsPageHandler();
- virtual bool Parse(const base::Value* value,
- Extension* extension,
- string16* error) OVERRIDE;
+ virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
};
// Parses the "chrome_url_overrides" manifest key.
@@ -103,9 +95,7 @@ class URLOverridesHandler : public ManifestHandler {
URLOverridesHandler();
virtual ~URLOverridesHandler();
- virtual bool Parse(const base::Value* value,
- Extension* extension,
- string16* error) OVERRIDE;
+ virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698