Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/common/extensions/manifest_url_handler.h

Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tts, TODO Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_URL_HANDLER_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_URL_HANDLER_H_
6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_URL_HANDLER_H_ 6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_URL_HANDLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "chrome/common/extensions/extension.h" 10 #include "chrome/common/extensions/extension.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 // which override the handling of those URLs. (see ExtensionOverrideUI). 52 // which override the handling of those URLs. (see ExtensionOverrideUI).
53 URLOverrideMap chrome_url_overrides_; 53 URLOverrideMap chrome_url_overrides_;
54 }; 54 };
55 55
56 // Parses the "devtools_page" manifest key. 56 // Parses the "devtools_page" manifest key.
57 class DevToolsPageHandler : public ManifestHandler { 57 class DevToolsPageHandler : public ManifestHandler {
58 public: 58 public:
59 DevToolsPageHandler(); 59 DevToolsPageHandler();
60 virtual ~DevToolsPageHandler(); 60 virtual ~DevToolsPageHandler();
61 61
62 virtual bool Parse(const base::Value* value, 62 virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
63 Extension* extension,
64 string16* error) OVERRIDE;
65 }; 63 };
66 64
67 // Parses the "homepage_url" manifest key. 65 // Parses the "homepage_url" manifest key.
68 class HomepageURLHandler : public ManifestHandler { 66 class HomepageURLHandler : public ManifestHandler {
69 public: 67 public:
70 HomepageURLHandler(); 68 HomepageURLHandler();
71 virtual ~HomepageURLHandler(); 69 virtual ~HomepageURLHandler();
72 70
73 virtual bool Parse(const base::Value* value, 71 virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
74 Extension* extension,
75 string16* error) OVERRIDE;
76 }; 72 };
77 73
78 // Parses the "update_url" manifest key. 74 // Parses the "update_url" manifest key.
79 class UpdateURLHandler : public ManifestHandler { 75 class UpdateURLHandler : public ManifestHandler {
80 public: 76 public:
81 UpdateURLHandler(); 77 UpdateURLHandler();
82 virtual ~UpdateURLHandler(); 78 virtual ~UpdateURLHandler();
83 79
84 virtual bool Parse(const base::Value* value, 80 virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
85 Extension* extension,
86 string16* error) OVERRIDE;
87 }; 81 };
88 82
89 // Parses the "options_page" manifest key. 83 // Parses the "options_page" manifest key.
90 class OptionsPageHandler : public ManifestHandler { 84 class OptionsPageHandler : public ManifestHandler {
91 public: 85 public:
92 OptionsPageHandler(); 86 OptionsPageHandler();
93 virtual ~OptionsPageHandler(); 87 virtual ~OptionsPageHandler();
94 88
95 virtual bool Parse(const base::Value* value, 89 virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
96 Extension* extension,
97 string16* error) OVERRIDE;
98 }; 90 };
99 91
100 // Parses the "chrome_url_overrides" manifest key. 92 // Parses the "chrome_url_overrides" manifest key.
101 class URLOverridesHandler : public ManifestHandler { 93 class URLOverridesHandler : public ManifestHandler {
102 public: 94 public:
103 URLOverridesHandler(); 95 URLOverridesHandler();
104 virtual ~URLOverridesHandler(); 96 virtual ~URLOverridesHandler();
105 97
106 virtual bool Parse(const base::Value* value, 98 virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
107 Extension* extension,
108 string16* error) OVERRIDE;
109 }; 99 };
110 100
111 } // namespace extensions 101 } // namespace extensions
112 102
113 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_URL_HANDLER_H_ 103 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_URL_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698