chrome/common/extensions/api/commands/commands_handler.h - Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/commands/commands_handler.h

Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tts, TODO Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_browser_handler.cc ('k') | chrome/common/extensions/api/commands/commands_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/commands/commands_handler.h

diff --git a/chrome/common/extensions/api/commands/commands_handler.h b/chrome/common/extensions/api/commands/commands_handler.h

index a426a0fa2f155f3481892297c42759d95205d901..6e4d7cca61c9bf63a71facc0c66d7ae538577b7c 100644

--- a/chrome/common/extensions/api/commands/commands_handler.h

+++ b/chrome/common/extensions/api/commands/commands_handler.h

@@ -39,11 +39,8 @@ class CommandsHandler : public ManifestHandler {

CommandsHandler();

virtual ~CommandsHandler();

- virtual bool Parse(const base::Value* value,

- Extension* extension,

- string16* error) OVERRIDE;

- virtual bool HasNoKey(Extension* extension, string16* error) OVERRIDE;

+ virtual bool Parse(Extension* extension, string16* error) OVERRIDE;

+ virtual bool AlwaysParseForType(Extension::Type type) OVERRIDE;

private:

// If the extension defines a browser action, but no command for it, then