Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_handler.cc

Issue 12084034: Change manifest handler interface to always (implicitly) pass the entire manifest to handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tts, TODO Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_browser_handler.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_handler.cc b/chrome/browser/chromeos/extensions/file_browser_handler.cc
index 697a0a488bc6325089eead0e857c70fd5f99d80a..3f708307c7da7242273e1d472691489cf0ac0444 100644
--- a/chrome/browser/chromeos/extensions/file_browser_handler.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_handler.cc
@@ -11,6 +11,7 @@
#include "base/values.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest.h"
#include "content/public/common/url_constants.h"
#include "extensions/common/error_utils.h"
#include "extensions/common/url_pattern.h"
@@ -334,11 +335,11 @@ bool LoadFileBrowserHandlers(
} // namespace
-bool FileBrowserHandlerParser::Parse(const base::Value* value,
- extensions::Extension* extension,
+bool FileBrowserHandlerParser::Parse(extensions::Extension* extension,
string16* error) {
const ListValue* file_browser_handlers_value = NULL;
- if (!value->GetAsList(&file_browser_handlers_value)) {
+ if (!extension->manifest()->GetList(keys::kFileBrowserHandlers,
+ &file_browser_handlers_value)) {
*error = ASCIIToUTF16(errors::kInvalidFileBrowserHandler);
return false;
}
« no previous file with comments | « chrome/browser/chromeos/extensions/file_browser_handler.h ('k') | chrome/common/extensions/api/commands/commands_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698