Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12082123: Rename JavaScriptDialogCreator to JavaScriptDialogManager. (Closed)

Created:
7 years, 10 months ago by kkania
Modified:
7 years, 10 months ago
Reviewers:
joth, jam
CC:
chromium-reviews, vsevik, tfarina, jam, yurys, joi+watch-content_chromium.org, Aaron Boodman, jochen+watch_chromium.org, darin-cc_chromium.org, dcheng, sail+watch_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, pfeldman
Visibility:
Public.

Description

Rename JavaScriptDialogCreator to JavaScriptDialogManager. It has taken on some responsibility besides just creating dialogs. I'm also planning on adding an additional method soon for accepting/dismissing an open dialog. BUG=none TBR=joth Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180194

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -884 lines) Patch
M android_webview/native/aw_browser_dependency_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +1 line, -1 line 0 comments Download
D android_webview/native/aw_javascript_dialog_creator.h View 1 chunk +0 lines, -41 lines 0 comments Download
D android_webview/native/aw_javascript_dialog_creator.cc View 1 chunk +0 lines, -63 lines 0 comments Download
A + android_webview/native/aw_javascript_dialog_manager.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + android_webview/native/aw_javascript_dialog_manager.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M android_webview/native/js_result_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/js_result_handler.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M android_webview/native/webview_native.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/app_modal_dialogs/javascript_dialog_creator.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/app_modal_dialogs/javascript_dialog_creator.cc View 1 chunk +0 lines, -277 lines 0 comments Download
A + chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.h View 1 chunk +9 lines, -9 lines 0 comments Download
A + chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc View 11 chunks +29 lines, -29 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/public/browser/javascript_dialog_manager.h View 3 chunks +7 lines, -7 lines 0 comments Download
D content/public/browser/javascript_dialogs.h View 1 chunk +0 lines, -56 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/shell/shell_javascript_dialog.h View 2 chunks +6 lines, -6 lines 0 comments Download
D content/shell/shell_javascript_dialog_creator.h View 1 chunk +0 lines, -64 lines 0 comments Download
D content/shell/shell_javascript_dialog_creator.cc View 1 chunk +0 lines, -142 lines 0 comments Download
M content/shell/shell_javascript_dialog_gtk.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/shell/shell_javascript_dialog_mac.mm View 5 chunks +13 lines, -13 lines 0 comments Download
A + content/shell/shell_javascript_dialog_manager.h View 2 chunks +10 lines, -10 lines 0 comments Download
A + content/shell/shell_javascript_dialog_manager.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/shell/shell_javascript_dialog_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/test/content_browser_test_utils.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kkania
jam: review content and chrome joth: review android_webview
7 years, 10 months ago (2013-02-01 19:23:54 UTC) #1
kkania
-ben, sorry for the spam
7 years, 10 months ago (2013-02-01 19:24:11 UTC) #2
jam
lgtm
7 years, 10 months ago (2013-02-01 21:37:50 UTC) #3
boliu
aw/ lgtm I'm not owner though. There are no aw owner on duty right now ...
7 years, 10 months ago (2013-02-01 21:46:00 UTC) #4
joth
7 years, 10 months ago (2013-02-04 19:05:26 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698