chrome/browser/devtools/devtools_window.cc - Issue 12082123: Rename JavaScriptDialogCreator to JavaScriptDialogManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 12082123: Rename JavaScriptDialogCreator to JavaScriptDialogManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index 1b09a374ac5bb708e506f833379807e44d31f144..cc00effa82bfa9711b50fd66c6159456baccc61a 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -913,12 +913,12 @@ void DevToolsWindow::FileSystemAdded(

delete file_system_value;

}

-content::JavaScriptDialogCreator* DevToolsWindow::GetJavaScriptDialogCreator() {

+content::JavaScriptDialogManager* DevToolsWindow::GetJavaScriptDialogManager() {

if (inspected_web_contents_ && inspected_web_contents_->GetDelegate()) {

return inspected_web_contents_->GetDelegate()->

- GetJavaScriptDialogCreator();

+ GetJavaScriptDialogManager();

}

- return content::WebContentsDelegate::GetJavaScriptDialogCreator();

+ return content::WebContentsDelegate::GetJavaScriptDialogManager();

}

void DevToolsWindow::RunFileChooser(WebContents* web_contents,