Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: media/base/simd/empty_register_state.h

Issue 12082087: Replace or exclude MMX intrinsics in yuv_convert_simd_x86 due to lack of VS2010 support for them in… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some lint errors Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/simd/empty_register_state.h
diff --git a/media/base/simd/empty_register_state.h b/media/base/simd/empty_register_state.h
new file mode 100644
index 0000000000000000000000000000000000000000..3f555931097b5344f4c34eb2fd493fe4cf4bb4c5
--- /dev/null
+++ b/media/base/simd/empty_register_state.h
@@ -0,0 +1,14 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_EMPTY_REGISTER_STATE_H_
scherkus (not reviewing) 2013/01/31 01:56:40 header guard is incorrect (missing SIMD)
wolenetz 2013/01/31 22:13:45 Done.
+#define MEDIA_BASE_EMPTY_REGISTER_STATE_H_
+
+// Assembly functions are declared without namespace.
+extern "C" {
+void EmptyRegisterState_MMX(void);
scherkus (not reviewing) 2013/01/31 01:56:40 a whole file for a single function seems a bit ove
wolenetz 2013/01/31 22:13:45 Offline with Dale and Alpha, there is no good othe
+} // extern "C"
+
+#endif // MEDIA_BASE_EMPTY_REGISTER_STATE_H_
wolenetz 2013/01/31 22:13:45 Fixed header guard comment here, too.
+
scherkus (not reviewing) 2013/01/31 01:56:40 remove extra blank line
wolenetz 2013/01/31 22:13:45 Done.

Powered by Google App Engine
This is Rietveld 408576698