media/base/simd/empty_register_state.h - Issue 12082087: Replace or exclude MMX intrinsics in yuv_convert_simd_x86 due to lack of VS2010 support for them in…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/simd/empty_register_state.h

Issue 12082087: Replace or exclude MMX intrinsics in yuv_convert_simd_x86 due to lack of VS2010 support for them in… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix some lint errors Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MEDIA_BASE_EMPTY_REGISTER_STATE_H_
	scherkus (not reviewing) 2013/01/31 01:56:40 header guard is incorrect (missing SIMD) header guard is incorrect (missing SIMD) wolenetz 2013/01/31 22:13:45 Done. Show quoted text On 2013/01/31 01:56:40, scherkus wrote: > header guard is incorrect (missing SIMD) Done.
	6 #define MEDIA_BASE_EMPTY_REGISTER_STATE_H_

	7

	8 // Assembly functions are declared without namespace.

	9 extern "C" {

	10 void EmptyRegisterState_MMX(void);
	scherkus (not reviewing) 2013/01/31 01:56:40 a whole file for a single function seems a bit ove a whole file for a single function seems a bit overkill ... is there an existing file we can shove this into? wolenetz 2013/01/31 22:13:45 Offline with Dale and Alpha, there is no good othe Show quoted text On 2013/01/31 01:56:40, scherkus wrote: > a whole file for a single function seems a bit overkill ... is there an existing > file we can shove this into? Offline with Dale and Alpha, there is no good other file to put this into currently.
	11 } // extern "C"

	12

	13 #endif // MEDIA_BASE_EMPTY_REGISTER_STATE_H_
	wolenetz 2013/01/31 22:13:45 Fixed header guard comment here, too. Fixed header guard comment here, too.
	14
	scherkus (not reviewing) 2013/01/31 01:56:40 remove extra blank line remove extra blank line wolenetz 2013/01/31 22:13:45 Done. Show quoted text On 2013/01/31 01:56:40, scherkus wrote: > remove extra blank line Done.
OLD	NEW

« media/base/simd/convert_yuv_to_rgb_x86.cc ('K') | « media/base/simd/convert_yuv_to_rgb_x86.cc ('k') | media/base/simd/empty_register_state_mmx.asm » ('j') | media/base/yuv_convert.cc » ('J')