Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 12082066: Merge 140778 (Closed)

Created:
7 years, 10 months ago by tkent
Modified:
7 years, 10 months ago
Reviewers:
keishi
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 140778 > Adjust design of the Calendar Picker > https://bugs.webkit.org/show_bug.cgi?id=107507 > > Reviewed by Kent Tamura. > > .: > > * ManualTests/forms/calendar-picker.html: Use pickerCommonChromium.css and calendarPickerChromium.css. > > Source/WebCore: > > Covered by existing calendar picker appearance tests. > > * Resources/pagepopups/calendarPicker.css: > (body): Use bigger font. > (.calendar-picker): > (.month-selector): > (.month-selector svg): > (.month-selector-popup-contents): > (.year-month-button-left .year-month-button): > (.year-month-button-right .year-month-button): > (.days-area-container): > (.days-area): > (.day-label): > (.day): > (.available): > (.month-mode .day): > (.today-clear-area .today-button): > * Resources/pagepopups/calendarPicker.js: > (CalendarPicker.prototype.fixWindowSize): Calculate the width of today-clear-area too. > (YearMonthController.prototype.attachTo): > (YearMonthController.prototype._attachLeftButtonsTo): Use svg icons inside buttons. > (YearMonthController.prototype._attachRightButtonsTo): Use svg icons inside buttons. > (YearMonthController.prototype.setMonth): > (YearMonthController.prototype._handleButtonClick): > * Resources/pagepopups/calendarPickerMac.css: Removed. > * Resources/pagepopups/chromium/calendarPickerChromium.css: Added. > (.year-month-button): > (.days-area-container:focus): > * Resources/pagepopups/chromium/pickerCommonChromium.css: Added. Use Chrome-style buttons. > (button): > (:enabled:hover:-webkit-any(button, input[type='button'])): > (:enabled:active:-webkit-any(button, input[type='button'])): > (:disabled:-webkit-any(button, input[type='button'])): > (:enabled:focus:-webkit-any(button, input[type='button'])): > * WebCore.gyp/WebCore.gyp: Include pickerCommonChromium.css and calendarPickerChromium.css. > * rendering/RenderTheme.cpp: Remove extraCalendarPickerStyleSheet > * rendering/RenderTheme.h: Ditto. > * rendering/RenderThemeChromiumMac.h: Ditto. > * rendering/RenderThemeChromiumMac.mm: Ditto. > (WebCore): > > Source/WebKit/chromium: > > * src/DateTimeChooserImpl.cpp: > (WebKit::DateTimeChooserImpl::writeDocument): Include pickerCommonChromium.css and calendarPickerChromium.css. > > LayoutTests: > > * platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html: > * platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt: > * platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt: > * platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html: > * platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt: > * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt: > * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt: > * platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt: > * platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html: > * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: > * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: > * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: > * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: > * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: > * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: > * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: > * platform/chromium/TestExpectations: Marking calendar picker appearance tests as needing rebaseline. TBR=keishi@webkit.org BUG=crbug.com/172514 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -164 lines) Patch
M LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/TestExpectations View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M ManualTests/forms/calendar-picker.html View 3 chunks +9 lines, -0 lines 0 comments Download
M Source/WebCore/Resources/pagepopups/calendarPicker.css View 10 chunks +32 lines, -31 lines 0 comments Download
M Source/WebCore/Resources/pagepopups/calendarPicker.js View 8 chunks +34 lines, -30 lines 0 comments Download
D Source/WebCore/Resources/pagepopups/calendarPickerMac.css View 1 chunk +0 lines, -49 lines 0 comments Download
M Source/WebCore/WebCore.gyp/WebCore.gyp View 3 chunks +2 lines, -21 lines 0 comments Download
M Source/WebCore/rendering/RenderTheme.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/rendering/RenderTheme.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebCore/rendering/RenderThemeChromiumMac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/rendering/RenderThemeChromiumMac.mm View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/WebKit/chromium/src/DateTimeChooserImpl.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
7 years, 10 months ago (2013-01-30 03:32:29 UTC) #1
tkent
On 2013/01/30 03:32:29, Kent Tamura wrote: The change lacks WebCore/Resources/pagepopups/chromium/*.css. Revering...
7 years, 10 months ago (2013-01-30 03:41:21 UTC) #2
tkent
7 years, 10 months ago (2013-01-30 03:55:56 UTC) #3
Message was sent while issue was closed.
> The change lacks WebCore/Resources/pagepopups/chromium/*.css.  Revering...

I added these files manually instead of reverting.

Powered by Google App Engine
This is Rietveld 408576698