Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: runtime/observatory/lib/src/elements/code_view.dart

Issue 1208153002: Include pattern and functions for RegExps over the service protocol. Remove quadratic behavior from… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/instance_ref.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/code_view.dart
diff --git a/runtime/observatory/lib/src/elements/code_view.dart b/runtime/observatory/lib/src/elements/code_view.dart
index 4995996fa3754ab019c28dbc5c99cc36e8226c69..7c6ddef97d1b28122d24740aed1d7edbf1a09a59 100644
--- a/runtime/observatory/lib/src/elements/code_view.dart
+++ b/runtime/observatory/lib/src/elements/code_view.dart
@@ -197,9 +197,10 @@ class CodeViewElement extends ObservatoryElement {
}
void _fillDisassemblyDOMRow(TableRowElement tr, int rowIndex) {
- var row = disassemblyTable.rows[rowIndex];
- for (var i = 0; i < row.values.length; i++) {
- var cell = tr.children[i];
+ final row = disassemblyTable.rows[rowIndex];
+ final n = row.values.length;
+ for (var i = 0; i < n; i++) {
+ final cell = tr.children[i];
cell.title = row.values[i].toString();
cell.text = row.values[i].toString();
}
@@ -226,11 +227,13 @@ class CodeViewElement extends ObservatoryElement {
}
assert(tableBody.children.length == disassemblyTable.sortedRows.length);
+
// Fill table.
- for (var i = 0; i < disassemblyTable.sortedRows.length; i++) {
+ var i = 0;
+ for (var tr in tableBody.children) {
var rowIndex = disassemblyTable.sortedRows[i];
- var tr = tableBody.children[i];
_fillDisassemblyDOMRow(tr, rowIndex);
+ i++;
}
}
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/instance_ref.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698