Include pattern and functions for RegExps over the service protocol. Remove quadratic behavior from…

runtime/observatory/lib/src/elements/code_view.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_view_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'observatory_element.dart';
 import 'package:observatory/app.dart';
@@ skipping 179 matching lines @@
     cell.classes.add('monospace');
     cell = tr.insertCell(-1);
     cell.classes.add('monospace');
     cell = tr.insertCell(-1);
     cell.classes.add('monospace');
 
     tableBody.children.add(tr);
   }
 
   void _fillDisassemblyDOMRow(TableRowElement tr, int rowIndex) {
-    var row = disassemblyTable.rows[rowIndex];
-    for (var i = 0; i < row.values.length; i++) {
-      var cell = tr.children[i];
+    final row = disassemblyTable.rows[rowIndex];
+    final n = row.values.length;
+    for (var i = 0; i < n; i++) {
+      final cell = tr.children[i];
       cell.title = row.values[i].toString();
       cell.text = row.values[i].toString();
     }
   }
 
   void _updateDisassemblyDOMTable() {
     var tableBody = $['disassemblyTableBody'];
     assert(tableBody != null);
     // Resize DOM table.
     if (tableBody.children.length > disassemblyTable.sortedRows.length) {
       // Shrink the table.
       var deadRows =
       tableBody.children.length - disassemblyTable.sortedRows.length;
       for (var i = 0; i < deadRows; i++) {
         tableBody.children.removeLast();
       }
     } else if (tableBody.children.length < disassemblyTable.sortedRows.length) {
       // Grow table.
       var newRows =
           disassemblyTable.sortedRows.length - tableBody.children.length;
       for (var i = 0; i < newRows; i++) {
         _addDisassemblyDOMRow();
       }
     }
 
     assert(tableBody.children.length == disassemblyTable.sortedRows.length);
+
     // Fill table.
-    for (var i = 0; i < disassemblyTable.sortedRows.length; i++) {
+    var i = 0;
+    for (var tr in tableBody.children) {
       var rowIndex = disassemblyTable.sortedRows[i];
-      var tr = tableBody.children[i];
       _fillDisassemblyDOMRow(tr, rowIndex);
+      i++;
     }
   }
 
   void _updateDisassembly() {
     _updateDiasssemblyTable();
     _updateDisassemblyDOMTable();
   }
 
   void _updateInlineTable() {
     inlineTable.clearRows();
@@ skipping 117 matching lines @@
   }
 
   void mouseOut(Event e, var detail, Node target) {
     var jt = _findJumpTarget(target);
     if (jt == null) {
       return;
     }
     jt.classes.remove('highlight');
   }
 }