chrome/renderer/chrome_content_renderer_client.cc - Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swapped_out_cmdline_checks

Patch Set: Partial fixes to Nasko's comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/task_manager_browsertest.cc ('k') | components/guest_view/browser/guest_view_base.cc » ('j') | content/browser/child_process_security_policy_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index f8779f4b223d93ee564b07599f45c2e96763e64f..7e6455c453a75ca6e987a23af1d8ba2b52f2ddbd 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -1400,6 +1400,8 @@ bool ChromeContentRendererClient::CrossesExtensionExtents(

// the type of process. In default Chrome, that's the URL of the opener's

// top frame and not the opener frame itself. In --site-per-process, we

// can use the opener frame itself.

+ // TODO(nick): Either wire this up to SiteIsolationPolicy, or to state on

+ // |opener_frame|/its ancestors.

Charlie Reis 2015/07/13 22:13:14 Yeah, this one's a bit awkward, since there's a ch

ncarter (slow) 2015/07/20 17:45:46 Acknowledged.

if (base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kSitePerProcess))

old_url = opener_frame->document().url();