chrome/browser/task_manager/task_manager_browsertest.cc - Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_browsertest.cc

Issue 1208143002: Move existing kSitePerProcess checks to a policy-oracle object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swapped_out_cmdline_checks

Patch Set: Partial fixes to Nasko's comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_site_per_process_browsertest.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager_browsertest.cc

diff --git a/chrome/browser/task_manager/task_manager_browsertest.cc b/chrome/browser/task_manager/task_manager_browsertest.cc

index 5d13c532a6f1c08af84ae2eb7eca42ca61b43106..4699d67b07f4464781a1f25bfb1790139dbd35c1 100644

--- a/chrome/browser/task_manager/task_manager_browsertest.cc

+++ b/chrome/browser/task_manager/task_manager_browsertest.cc

@@ -38,7 +38,7 @@

#include "content/public/browser/notification_service.h"

#include "content/public/browser/page_navigator.h"

#include "content/public/browser/render_frame_host.h"

-#include "content/public/common/content_switches.h"

+#include "content/public/common/site_isolation_policy.h"

#include "content/public/test/browser_test_utils.h"

#include "content/public/test/content_browser_test_utils.h"

#include "extensions/browser/extension_system.h"

@@ -159,12 +159,11 @@ class TaskManagerOOPIFBrowserTest : public TaskManagerBrowserTest,

void SetUpCommandLine(base::CommandLine* command_line) override {

TaskManagerBrowserTest::SetUpCommandLine(command_line);

if (GetParam())

- command_line->AppendSwitch(switches::kSitePerProcess);

+ content::SiteIsolationPolicy::IsolateAllSitesForTesting(command_line);

}

bool ShouldExpectSubframes() {

- return base::CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kSitePerProcess);

+ return content::SiteIsolationPolicy::AreAllSitesIsolatedForTesting();

}

private: