Issue 1208103006: Try harder to work around a clang/win bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1208103006: Try harder to work around a clang/win bug. (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
jkarlin

CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Try harder to work around a clang/win bug. This is a follow-up to https://codereview.chromium.org/1215613006 which didn't help. BUG=BUG=488634 TBR=jkarlin@chromium.org

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	content/browser/background_sync/background_sync_registration_options.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	content/browser/background_sync/background_sync_registration_options.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208103006/1

5 years, 5 months ago (2015-07-03 21:33:50 UTC) #4

Nico

Committed patchset #1 (id:1) to pending queue manually as 44da30239c1bd20a50b7eb3f63d0f5f0b9aece10 (presubmit successful).

5 years, 5 months ago (2015-07-03 22:04:24 UTC) #5

Nico

5 years, 5 months ago (2015-07-04 04:33:42 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1221433004/ by thakis@chromium.org.

The reason for reverting is: Looks like this is unnecessary; the first CL did
the trick already..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages