Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1208053003: Fix slash direction: paths in msysgit use /, not \. (Closed)

Created:
5 years, 5 months ago by Peter Kasting
Modified:
5 years, 5 months ago
Reviewers:
Michael Moss, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix slash direction: paths in msysgit use /, not \. BUG=none TEST=update_depot_tools actually works in msysgit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M update_depot_tools View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Kasting
mmoss: Review iannucci: OWNERS This was introduced in https://codereview.chromium.org/166273024 and, AFAICT, has been broken since ...
5 years, 5 months ago (2015-06-29 22:29:23 UTC) #2
Michael Moss
lgtm
5 years, 5 months ago (2015-06-29 22:31:01 UTC) #3
iannucci
rs-lgtm... godspeed...
5 years, 5 months ago (2015-06-29 22:52:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208053003/1
5 years, 5 months ago (2015-06-29 22:53:14 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 22:55:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295866

Powered by Google App Engine
This is Rietveld 408576698