More fixes for hardcoded git directory paths.

More fixes for hardcoded git directory paths.

The git path is based on the git version, so it might change whenever git is
updated. Run git.bat instead, since that's updated with new git installs and
should always point to the right path.

The mingw logic is based on similar handling of python.bat in git-cl.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=252584

[M-A Ruel, 2014-02-21 02:40:24]

somewhat rubberstamp lgtm

[Michael Moss, 2014-02-21 04:39:13]

On 2014/02/21 02:40:24, M-A Ruel wrote:
> somewhat rubberstamp lgtm

Is there anyone who's actually familiar with a mingw environment/workflow? Since
my change is somewhat rubber-copied from git-cl (with the additional 'eval'
handling), I'd feel more comfortable submitting with a more definitive LGTM. I
tested a bit with the depot_tools git-bash.bat environment, but I don't think
that's quite what this is targeting (it's actually unnecessary in that
environment, since plain old 'git' == depot_tools git).

[iannucci, 2014-02-21 08:25:07]

/me has no idea :(

https://codereview.chromium.org/166273024/diff/30001/update_depot_tools
File update_depot_tools (right):

https://codereview.chromium.org/166273024/diff/30001/update_depot_tools#newco...
update_depot_tools:20: base_dir="${0%\\*}"
TIL: bash variable expansion is freaking nuts :(

[Michael Moss, 2014-02-21 17:18:57]

On 2014/02/21 08:25:07, iannucci wrote:
> /me has no idea :(
> 
> https://codereview.chromium.org/166273024/diff/30001/update_depot_tools
> File update_depot_tools (right):
> 
>
https://codereview.chromium.org/166273024/diff/30001/update_depot_tools#newco...
> update_depot_tools:20: base_dir="${0%\\*}"
> TIL: bash variable expansion is freaking nuts :(

OK, I'm just going to go with it then. Easy enough to rollback if it breaks.

[Michael Moss, 2014-02-21 17:19:13]

The CQ bit was checked by mmoss@chromium.org

[commit-bot: I haz the power, 2014-02-21 17:19:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmoss@chromium.org/166273024/30001

[commit-bot: I haz the power, 2014-02-21 17:21:00]

Change committed as 252584