Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Issue 1208013002: [turbofan] Implement sharing of context-independent code. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_opt-code-map-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implement sharing of context-independent code. This allows context-independent code generated by TurboFan to be cached in the optimized code map and reused across native contexts. Note that currently this cache is still flushed at GC time. R=bmeurer@chromium.org,mvstanton@chromium.org TEST=cctest/test-compiler/OptimizedCodeSharing Committed: https://crrev.com/317cb6538c5dcee14dea432fecc9cad5c9d1f605 Cr-Commit-Position: refs/heads/master@{#29313}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Actual implementation. #

Patch Set 4 : Some fixes. #

Patch Set 5 : One more fix. #

Total comments: 2

Patch Set 6 : Addressed comments. #

Patch Set 7 : Disable test for GC stress. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -33 lines) Patch
M src/code-stubs-hydrogen.cc View 1 2 5 chunks +33 lines, -6 lines 0 comments Download
M src/compiler.cc View 1 2 3 1 chunk +14 lines, -3 lines 0 comments Download
M src/factory.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 6 chunks +19 lines, -13 lines 0 comments Download
M src/objects.cc View 1 2 3 4 4 chunks +24 lines, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 2 3 4 5 6 3 chunks +66 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
Michael Starzinger
Michael: PTAL especially at the FastNewClosureStub port. Benedikt: PTAL at everything else.
5 years, 6 months ago (2015-06-25 13:12:44 UTC) #2
Benedikt Meurer
LGTM with comment. Thanks! https://codereview.chromium.org/1208013002/diff/80001/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/1208013002/diff/80001/src/code-stubs-hydrogen.cc#newcode1794 src/code-stubs-hydrogen.cc:1794: HValue* literals = Add<HConstant>(factory->empty_fixed_array()); Add ...
5 years, 6 months ago (2015-06-26 06:34:53 UTC) #3
mvstanton
Also LGTM, nice :).
5 years, 6 months ago (2015-06-26 06:38:37 UTC) #4
Michael Starzinger
https://codereview.chromium.org/1208013002/diff/80001/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/1208013002/diff/80001/src/code-stubs-hydrogen.cc#newcode1794 src/code-stubs-hydrogen.cc:1794: HValue* literals = Add<HConstant>(factory->empty_fixed_array()); On 2015/06/26 06:34:53, Benedikt Meurer ...
5 years, 6 months ago (2015-06-26 08:30:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208013002/120001
5 years, 6 months ago (2015-06-26 08:46:21 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 6 months ago (2015-06-26 09:07:37 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 09:07:55 UTC) #10
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/317cb6538c5dcee14dea432fecc9cad5c9d1f605
Cr-Commit-Position: refs/heads/master@{#29313}

Powered by Google App Engine
This is Rietveld 408576698