src/factory.cc - Issue 1208013002: [turbofan] Implement sharing of context-independent code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 1208013002: [turbofan] Implement sharing of context-independent code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_opt-code-map-3

Patch Set: Disable test for GC stress. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 6a01e019bf30f21f6de99cb41ecc715e72b989d8..7df095d19f1e14f93fac1def465748eb2db8093c 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1390,6 +1390,7 @@ Handle<JSFunction> Factory::NewFunctionFromSharedFunctionInfo(

if (cached.literals == nullptr && !info->bound()) {

int number_of_literals = info->num_literals();

+ // TODO(mstarzinger): Consider sharing the newly created literals array.

Handle<FixedArray> literals = NewFixedArray(number_of_literals, pretenure);

result->set_literals(*literals);

}

« no previous file with comments | « src/compiler.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »