Trigger DidChangeVisisbleSSLState() after OverrideEntry()

chrome/browser/ui/browser_browsertest.cc

Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 73ae3e2e1446401fadebc506a17095c46c4f383d..9682b1bdcc9fae3066c6a5e76fea151f99c0accf 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -357,6 +357,10 @@ class SecurityStyleTestObserver : public WebContentsObserver {
     return latest_security_style_;
   }
 
+  void ClearLatestSecurityStyle() {
+    latest_security_style_ = content::SECURITY_STYLE_UNKNOWN;
+  }
+
  private:
   content::SecurityStyle latest_security_style_;
 
@@ -2864,7 +2868,13 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, SecurityStyleChangedObserver) {
   GURL expired_url(https_test_server_expired.GetURL(std::string()));
   ui_test_utils::NavigateToURL(browser(), expired_url);
 
+  EXPECT_EQ(content::SECURITY_STYLE_AUTHENTICATION_BROKEN,

[nasko, 2015/06/25 12:59:32]

We expect to have an interstitial page being displayed at this time, correct? If
so, let's add an EXPECT to ensure that's the case.
Also, some comments on what is expected and most importantly why, are very
useful when you come back a year from now looking at the code :).

[estark, 2015/06/25 14:54:44]

Done.

+            observer.latest_security_style());
+
+  observer.ClearLatestSecurityStyle();
+
   ProceedThroughInterstitial(web_contents);
+

[nasko, 2015/06/25 12:59:32]

nit: Why the extra empty line here?

[estark, 2015/06/25 14:54:44]

Done.

   EXPECT_EQ(content::SECURITY_STYLE_AUTHENTICATION_BROKEN,
             observer.latest_security_style());

[nasko, 2015/06/25 12:59:32]

Do we have a test that ensures that if the user types a different URL or
navigates back after the interstitial is shown (but not proceeded through), the
SSL indicators are properly updated?

[estark, 2015/06/25 14:54:44]

Going back (as in "clicking the back button") doesn't seem to actually work for
interstitials. In a new tab, https://expired.badssl.com -> https://badssl.com ->
click Back takes you back to the new tab page. It's already filed
(crbug.com/311500) and I assume this is one of the things that'll be fixed by
the interstitial refactor.

In the meantime, I added a test that navigates away from the interstitial to a
different URL and then navigates back to the interstitial by navigating to the
bad https url again.

[nasko, 2015/06/26 08:53:04]

I meant this one indeed. Thanks for adding it!

 }