Trigger DidChangeVisisbleSSLState() after OverrideEntry()

chrome/browser/ui/browser_browsertest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
@@ skipping 339 matching lines @@
   ~SecurityStyleTestObserver() override {}
 
   void SecurityStyleChanged(content::SecurityStyle security_style) override {
     latest_security_style_ = security_style;
   }
 
   content::SecurityStyle latest_security_style() const {
     return latest_security_style_;
   }
 
+  void ClearLatestSecurityStyle() {
+    latest_security_style_ = content::SECURITY_STYLE_UNKNOWN;
+  }
+
  private:
   content::SecurityStyle latest_security_style_;
 
   DISALLOW_COPY_AND_ASSIGN(SecurityStyleTestObserver);
 };
 
 }  // namespace
 
 class BrowserTest : public ExtensionBrowserTest {
  protected:
@@ skipping 2487 matching lines @@
   GURL mixed_content_url(https_test_server.GetURL(replacement_path));
   ui_test_utils::NavigateToURL(browser(), mixed_content_url);
   EXPECT_EQ(content::SECURITY_STYLE_WARNING, observer.latest_security_style());
 
   // Visit a broken HTTPS url. Other conditions cannot be tested after
   // this one because once the interstitial is clicked through, all URLs
   // for this host will remain in a broken state.
   GURL expired_url(https_test_server_expired.GetURL(std::string()));
   ui_test_utils::NavigateToURL(browser(), expired_url);
 
+  EXPECT_EQ(content::SECURITY_STYLE_AUTHENTICATION_BROKEN,

[nasko, 2015/06/25 12:59:32]

We expect to have an interstitial page being displayed at this time, correct? If
so, let's add an EXPECT to ensure that's the case.
Also, some comments on what is expected and most importantly why, are very
useful when you come back a year from now looking at the code :).

[estark, 2015/06/25 14:54:44]

Done.

+            observer.latest_security_style());
+
+  observer.ClearLatestSecurityStyle();
+
   ProceedThroughInterstitial(web_contents);
+

[nasko, 2015/06/25 12:59:32]

nit: Why the extra empty line here?

[estark, 2015/06/25 14:54:44]

Done.

   EXPECT_EQ(content::SECURITY_STYLE_AUTHENTICATION_BROKEN,
             observer.latest_security_style());

[nasko, 2015/06/25 12:59:32]

Do we have a test that ensures that if the user types a different URL or
navigates back after the interstitial is shown (but not proceeded through), the
SSL indicators are properly updated?

[estark, 2015/06/25 14:54:44]

Going back (as in "clicking the back button") doesn't seem to actually work for
interstitials. In a new tab, https://expired.badssl.com -> https://badssl.com ->
click Back takes you back to the new tab page. It's already filed
(crbug.com/311500) and I assume this is one of the things that'll be fixed by
the interstitial refactor.

In the meantime, I added a test that navigates away from the interstitial to a
different URL and then navigates back to the interstitial by navigating to the
bad https url again.

[nasko, 2015/06/26 08:53:04]

I meant this one indeed. Thanks for adding it!

 }