DescriptionMerge 140791
> INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
> https://bugs.webkit.org/show_bug.cgi?id=107918
>
> Reviewed by Kentaro Hara.
>
> DateTimeSymbolicFieldElement::minimum() and maximum() are very
> confusing. They don't return minimum/maximum value of 0-based symbol
> index though valueAsInteger is 0-based. These functions are used only
> for ARIA attributes in DateTimeFieldElement::initialize().
>
> - Remove DateTimeFieldElement::minimum() and maximum(), and pass
> minimum/maximum values for ARIA attributes as function arguments.
> - DateTimeNumericFieldElement::maximum() is now non-virtual.
> It is called by subclasses.
>
> No new tests. This should not change any behavior.
>
> * html/shadow/DateTimeFieldElement.cpp:
> (WebCore::DateTimeFieldElement::initialize):
> Add axMimimum/axMaximum arguments. Don't use minimum() and maximum().
> * html/shadow/DateTimeFieldElement.h:
> (DateTimeFieldElement): Ditto.
> * html/shadow/DateTimeNumericFieldElement.cpp:
> (WebCore::DateTimeNumericFieldElement::initialize):
> Pass m_range.minimum and maximum to DateTimeFieldElement::initialize().
> * html/shadow/DateTimeNumericFieldElement.h:
> (DateTimeNumericFieldElement):
> - Add initialize()
> - Make maximum() non-virtual
> - Remove minimum().
> * html/shadow/DateTimeSymbolicFieldElement.cpp:
> (WebCore::DateTimeSymbolicFieldElement::initialize):
> Pass m_minimumIndex + 1 and m_maximumIndex + 1 to
> DateTimeFieldElement::initialize().
> * html/shadow/DateTimeSymbolicFieldElement.h:
> (DateTimeSymbolicFieldElement):
> Add initialize() and remove minimum() and maximum().
TBR=tkent@chromium.org
BUG=crbug.com/172199
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141200
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|