Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 12079062: Merge 140791 (Closed)

Created:
7 years, 10 months ago by tkent
Modified:
7 years, 10 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 140791 > INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement > https://bugs.webkit.org/show_bug.cgi?id=107918 > > Reviewed by Kentaro Hara. > > DateTimeSymbolicFieldElement::minimum() and maximum() are very > confusing. They don't return minimum/maximum value of 0-based symbol > index though valueAsInteger is 0-based. These functions are used only > for ARIA attributes in DateTimeFieldElement::initialize(). > > - Remove DateTimeFieldElement::minimum() and maximum(), and pass > minimum/maximum values for ARIA attributes as function arguments. > - DateTimeNumericFieldElement::maximum() is now non-virtual. > It is called by subclasses. > > No new tests. This should not change any behavior. > > * html/shadow/DateTimeFieldElement.cpp: > (WebCore::DateTimeFieldElement::initialize): > Add axMimimum/axMaximum arguments. Don't use minimum() and maximum(). > * html/shadow/DateTimeFieldElement.h: > (DateTimeFieldElement): Ditto. > * html/shadow/DateTimeNumericFieldElement.cpp: > (WebCore::DateTimeNumericFieldElement::initialize): > Pass m_range.minimum and maximum to DateTimeFieldElement::initialize(). > * html/shadow/DateTimeNumericFieldElement.h: > (DateTimeNumericFieldElement): > - Add initialize() > - Make maximum() non-virtual > - Remove minimum(). > * html/shadow/DateTimeSymbolicFieldElement.cpp: > (WebCore::DateTimeSymbolicFieldElement::initialize): > Pass m_minimumIndex + 1 and m_maximumIndex + 1 to > DateTimeFieldElement::initialize(). > * html/shadow/DateTimeSymbolicFieldElement.h: > (DateTimeSymbolicFieldElement): > Add initialize() and remove minimum() and maximum(). TBR=tkent@chromium.org BUG=crbug.com/172199 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M Source/WebCore/html/shadow/DateTimeFieldElement.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/html/shadow/DateTimeFieldElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebCore/html/shadow/DateTimeNumericFieldElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
7 years, 10 months ago (2013-01-30 02:17:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698