Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp

Issue 12079062: Merge 140791 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp
===================================================================
--- Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp (revision 141197)
+++ Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp (working copy)
@@ -87,16 +87,14 @@
return m_selectedIndex >= 0;
}
-int DateTimeSymbolicFieldElement::maximum() const
+void DateTimeSymbolicFieldElement::initialize(const AtomicString& pseudo, const String& axHelpText)
{
- return static_cast<int>(m_symbols.size());
+ // The minimum and maximum below are exposed to users, and 1-based numbers
+ // are natural for symbolic fields. For example, the minimum value of a
+ // month field should be 1, not 0.
+ DateTimeFieldElement::initialize(pseudo, axHelpText, 1, static_cast<int>(m_symbols.size()));
}
-int DateTimeSymbolicFieldElement::minimum() const
-{
- return 1;
-}
-
void DateTimeSymbolicFieldElement::setEmptyValue(EventBehavior eventBehavior)
{
if (isReadOnly())
« no previous file with comments | « Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698