Chromium Code Reviews
Help | Chromium Project | Sign in
(20)

Issue 12079053: cros: Bind Ctrl-M to minimize window (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by James Cook
Modified:
1 year, 2 months ago
Reviewers:
mazda
CC:
chromium-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, mazda+watch_chromium.org, arv, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

cros: Bind Ctrl-M to minimize window

BUG=172629
TEST=manual, it works and appears in the keyboard overlay (Ctrl-Alt-/)
TBR=xiyuan for trivial change to chrome/browser/chromeos/resources

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Lint Patch
M ash/accelerators/accelerator_table.cc View 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +1 line, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 8
James Cook
mazda, PTAL. Is this all that I need to do to add a keyboard shortcut?
1 year, 2 months ago #1
mazda
lgtm
1 year, 2 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/12079053/1
1 year, 2 months ago #3
I haz the power (commit-bot)
Presubmit check for 12079053-1 failed and returned exit status 1. Running presubmit commit checks ...
1 year, 2 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/12079053/1
1 year, 2 months ago #5
I haz the power (commit-bot)
Step "update" is always a major failure. Look at the try server FAQ for more ...
1 year, 2 months ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/12079053/1
1 year, 2 months ago #7
I haz the power (commit-bot)
1 year, 2 months ago #8
Message was sent while issue was closed.
Change committed as 179717
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6