Issue 12079011: Update system tray if vpn networks appear

Issue 12079011: Update system tray if vpn networks appear (Closed)

Created:
7 years, 11 months ago by stevenjb

Modified:
7 years, 10 months ago

Reviewers:
jennyz

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update system tray if vpn networks appear BUG=171587 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179215

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add comments #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -72 lines)			Patch
M	ash/system/chromeos/network/tray_vpn.cc	View	1	4 chunks	+18 lines, -5 lines	0 comments	Download
M	ash/system/tray/system_tray.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/system/tray/system_tray_bubble.cc	View	1	3 chunks	+69 lines, -61 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_icon.cc	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jennyz

lgtm with nits. https://codereview.chromium.org/12079011/diff/1/ash/system/chromeos/network/tray_vpn.cc File ash/system/chromeos/network/tray_vpn.cc (right): https://codereview.chromium.org/12079011/diff/1/ash/system/chromeos/network/tray_vpn.cc#newcode206 ash/system/chromeos/network/tray_vpn.cc:206: } else if (tray::VpnDefaultView::ShouldShow()) { It ...

7 years, 10 months ago (2013-01-28 19:49:58 UTC) #2

stevenjb

https://codereview.chromium.org/12079011/diff/1/ash/system/chromeos/network/tray_vpn.cc File ash/system/chromeos/network/tray_vpn.cc (right): https://codereview.chromium.org/12079011/diff/1/ash/system/chromeos/network/tray_vpn.cc#newcode206 ash/system/chromeos/network/tray_vpn.cc:206: } else if (tray::VpnDefaultView::ShouldShow()) { On 2013/01/28 19:49:58, jennyz ...

7 years, 10 months ago (2013-01-28 19:56:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12079011/5001

7 years, 10 months ago (2013-01-28 19:56:25 UTC) #4

Message was sent while issue was closed.

Change committed as 179215

Expand Messages | Collapse Messages