Update system tray if vpn networks appear

ash/system/tray/system_tray_bubble.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/system_tray_bubble.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/system_tray_item.h"
@@ skipping 15 matching lines @@
 
 namespace {
 
 // Normally a detailed view is the same size as the default view. However,
 // when showing a detailed view directly (e.g. clicking on a notification),
 // we may not know the height of the default view, or the default view may
 // be too short, so we use this as a default and minimum height for any
 // detailed view.
 const int kDetailedBubbleMaxHeight = kTrayPopupItemHeight * 5;
 
+// Duration of swipe animation used when transitioning from a default to
+// detailed view or vice versa.
+const int kSwipeDelayMS = 150;
+
 // A view with some special behaviour for tray items in the popup:
 // - optionally changes background color on hover.
 class TrayPopupItemContainer : public views::View {
  public:
   TrayPopupItemContainer(views::View* view,
                          bool change_background,
                          bool draw_border)
       : hover_(false),
         change_background_(change_background) {
     set_notify_enter_exit_on_child(true);
@@ skipping 96 matching lines @@
   DestroyItemViews();
   // Reset the host pointer in bubble_view_ in case its destruction is deferred.
   if (bubble_view_)
     bubble_view_->reset_delegate();
 }
 
 void SystemTrayBubble::UpdateView(
     const std::vector<ash::SystemTrayItem*>& items,
     BubbleType bubble_type) {
   DCHECK(bubble_type != BUBBLE_TYPE_NOTIFICATION);
-  DCHECK(bubble_type != bubble_type_);
 
-  const int kSwipeDelayMS = 150;
-  base::TimeDelta swipe_duration =
-      base::TimeDelta::FromMilliseconds(kSwipeDelayMS);
-  scoped_ptr<ui::Layer> scoped_layer(bubble_view_->RecreateLayer());
-  // Keep the reference to layer as we need it after releasing it.
-  ui::Layer* layer = scoped_layer.get();
-  DCHECK(layer);
-  layer->SuppressPaint();
+  scoped_ptr<ui::Layer> scoped_layer;
+  if (bubble_type != bubble_type_) {
+    base::TimeDelta swipe_duration =
+        base::TimeDelta::FromMilliseconds(kSwipeDelayMS);
+    scoped_layer.reset(bubble_view_->RecreateLayer());
+    // Keep the reference to layer as we need it after releasing it.
+    ui::Layer* layer = scoped_layer.get();
+    DCHECK(layer);
+    layer->SuppressPaint();
 
-  // When transitioning from detailed view to default view, animate the existing
-  // view (slide out towards the right).
-  if (bubble_type == BUBBLE_TYPE_DEFAULT) {
-    // Make sure the old view is visibile over the new view during the
-    // animation.
-    layer->parent()->StackAbove(layer, bubble_view_->layer());
-    ui::ScopedLayerAnimationSettings settings(layer->GetAnimator());
-    settings.AddObserver(
-        new AnimationObserverDeleteLayer(scoped_layer.release()));
-    settings.SetTransitionDuration(swipe_duration);
-    settings.SetTweenType(ui::Tween::EASE_OUT);
-    gfx::Transform transform;
-    transform.Translate(layer->bounds().width(), 0.0);
-    layer->SetTransform(transform);
-  }
+    // When transitioning from detailed view to default view, animate the
+    // existing view (slide out towards the right).
+    if (bubble_type == BUBBLE_TYPE_DEFAULT) {
+      // Make sure the old view is visibile over the new view during the
+      // animation.
+      layer->parent()->StackAbove(layer, bubble_view_->layer());
+      ui::ScopedLayerAnimationSettings settings(layer->GetAnimator());
+      settings.AddObserver(
+          new AnimationObserverDeleteLayer(scoped_layer.release()));
+      settings.SetTransitionDuration(swipe_duration);
+      settings.SetTweenType(ui::Tween::EASE_OUT);
+      gfx::Transform transform;
+      transform.Translate(layer->bounds().width(), 0.0);
+      layer->SetTransform(transform);
+    }
 
-  {
-    // Add a shadow layer to make the old layer darker as the animation
-    // progresses.
-    ui::Layer* shadow = new ui::Layer(ui::LAYER_SOLID_COLOR);
-    shadow->SetColor(SK_ColorBLACK);
-    shadow->SetOpacity(0.01f);
-    shadow->SetBounds(layer->bounds());
-    layer->Add(shadow);
-    layer->StackAtTop(shadow);
     {
-      // Animate the darkening effect a little longer than the swipe-in. This is
-      // to make sure the darkening animation does not end up finishing early,
-      // because the dark layer goes away at the end of the animation, and there
-      // is a brief moment when the old view is still visible, but it does not
-      // have the shadow layer on top.
-      ui::ScopedLayerAnimationSettings settings(shadow->GetAnimator());
-      settings.AddObserver(new AnimationObserverDeleteLayer(shadow));
-      settings.SetTransitionDuration(swipe_duration +
-                                     base::TimeDelta::FromMilliseconds(150));
-      settings.SetTweenType(ui::Tween::LINEAR);
-      shadow->SetOpacity(0.15f);
+      // Add a shadow layer to make the old layer darker as the animation
+      // progresses.
+      ui::Layer* shadow = new ui::Layer(ui::LAYER_SOLID_COLOR);
+      shadow->SetColor(SK_ColorBLACK);
+      shadow->SetOpacity(0.01f);
+      shadow->SetBounds(layer->bounds());
+      layer->Add(shadow);
+      layer->StackAtTop(shadow);
+      {
+        // Animate the darkening effect a little longer than the swipe-in. This
+        // is to make sure the darkening animation does not end up finishing
+        // early, because the dark layer goes away at the end of the animation,
+        // and there is a brief moment when the old view is still visible, but
+        // it does not have the shadow layer on top.
+        ui::ScopedLayerAnimationSettings settings(shadow->GetAnimator());
+        settings.AddObserver(new AnimationObserverDeleteLayer(shadow));
+        settings.SetTransitionDuration(swipe_duration +
+                                       base::TimeDelta::FromMilliseconds(150));
+        settings.SetTweenType(ui::Tween::LINEAR);
+        shadow->SetOpacity(0.15f);
+      }
     }
   }
 
   DestroyItemViews();
   bubble_view_->RemoveAllChildViews(true);
 
   items_ = items;
   bubble_type_ = bubble_type;
   CreateItemViews(
       Shell::GetInstance()->system_tray_delegate()->GetUserLoginStatus());
 
   // Close bubble view if we failed to create the item view.
   if (!bubble_view_->has_children()) {
     Close();
     return;
   }
 
   bubble_view_->GetWidget()->GetContentsView()->Layout();
   // Make sure that the bubble is large enough for the default view.
   if (bubble_type_ == BUBBLE_TYPE_DEFAULT) {
     bubble_view_->SetMaxHeight(0);  // Clear max height limit.
   }
 
-  // When transitioning from default view to detailed view, animate the new
-  // view (slide in from the right).
-  if (bubble_type == BUBBLE_TYPE_DETAILED) {
-    ui::Layer* new_layer = bubble_view_->layer();
-    gfx::Rect bounds = new_layer->bounds();
-    gfx::Transform transform;
-    transform.Translate(bounds.width(), 0.0);
-    new_layer->SetTransform(transform);
-    {
-      ui::ScopedLayerAnimationSettings settings(new_layer->GetAnimator());
-      settings.AddObserver(
-          new AnimationObserverDeleteLayer(scoped_layer.release()));
-      settings.SetTransitionDuration(swipe_duration);
-      settings.SetTweenType(ui::Tween::EASE_OUT);
-      new_layer->SetTransform(gfx::Transform());
+  if (scoped_layer.get()) {
+    // When transitioning from default view to detailed view, animate the new
+    // view (slide in from the right).
+    if (bubble_type == BUBBLE_TYPE_DETAILED) {
+      ui::Layer* new_layer = bubble_view_->layer();
+      gfx::Rect bounds = new_layer->bounds();
+      gfx::Transform transform;
+      transform.Translate(bounds.width(), 0.0);
+      new_layer->SetTransform(transform);
+      {
+        ui::ScopedLayerAnimationSettings settings(new_layer->GetAnimator());
+        settings.AddObserver(
+            new AnimationObserverDeleteLayer(scoped_layer.release()));
+        settings.SetTransitionDuration(
+            base::TimeDelta::FromMilliseconds(kSwipeDelayMS));
+        settings.SetTweenType(ui::Tween::EASE_OUT);
+        new_layer->SetTransform(gfx::Transform());
+      }
     }
   }
 }
 
 void SystemTrayBubble::InitView(views::View* anchor,
                                 user::LoginStatus login_status,
                                 TrayBubbleView::InitParams* init_params) {
   DCHECK(bubble_view_ == NULL);
 
   if (bubble_type_ == BUBBLE_TYPE_DETAILED &&
@@ skipping 97 matching lines @@
       bool is_default_bubble = bubble_type_ == BUBBLE_TYPE_DEFAULT;
       bubble_view_->AddChildView(new TrayPopupItemContainer(
           view, is_default_bubble,
           is_default_bubble && (i < items_.size() - 2)));
     }
   }
 }
 
 }  // namespace internal
 }  // namespace ash