PlatformThreadHandle: remove public id() interface

base/threading/platform_thread.h

Index: base/threading/platform_thread.h
diff --git a/base/threading/platform_thread.h b/base/threading/platform_thread.h
index 0b922650f0cf405878b6d345bb98f6c2959333c3..9a46576889f743ffc5563e3c5cfbd463b6bdbe04 100644
--- a/base/threading/platform_thread.h
+++ b/base/threading/platform_thread.h
@@ -73,26 +73,9 @@ class PlatformThreadHandle {
   typedef pthread_t Handle;
 #endif
 
-  PlatformThreadHandle()
-      : handle_(0),
-        id_(0) {
-  }
-
-  explicit PlatformThreadHandle(Handle handle)
-      : handle_(handle),
-        id_(0) {
-  }
-
-  PlatformThreadHandle(Handle handle,
-                       PlatformThreadId id)
-      : handle_(handle),
-        id_(id) {
-  }
+  PlatformThreadHandle() : handle_(0) {}
 
-  // TODO(toyoshim): Remove id() and use PlatformThread::CurrentId() instead.
-  PlatformThreadId id() const {
-    return id_;
-  }
+  explicit PlatformThreadHandle(Handle handle) : handle_(handle) {}
 
   bool is_equal(const PlatformThreadHandle& other) const {
     return handle_ == other.handle_;
@@ -102,13 +85,11 @@ class PlatformThreadHandle {
     return !handle_;
   }
 
-  Handle platform_handle() const {
-    return handle_;
-  }
-
  private:
+  friend class MessagePumpForUI;
+  friend class PlatformThread;
+  friend class ThreadIdNameManager;

[gab, 2015/06/30 13:57:34]

I don't like using friend and I don't think I mind that the const
platform_handle() getter be usable outside of these classes (it's not really
useful there anyways).

Can we initially focus on getting rid of only id() and perhaps think about this
use case independently after if the exposure of the public const call is really
an issue?

[Takashi Toyoshima, 2015/07/02 06:34:28]

OK, let me upload another patch set.

   Handle handle_;
-  PlatformThreadId id_;
 };
 
 const PlatformThreadId kInvalidThreadId(0);