PlatformThreadHandle: remove public id() interface

base/threading/platform_thread.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // WARNING: You should *NOT* be using this class directly.  PlatformThread is
 // the low-level platform-specific abstraction to the OS's threading interface.
 // You should instead be using a message-loop driven Thread, see thread.h.
 
 #ifndef BASE_THREADING_PLATFORM_THREAD_H_
 #define BASE_THREADING_PLATFORM_THREAD_H_
@@ skipping 55 matching lines @@
 
 // Used to operate on threads.
 class PlatformThreadHandle {
  public:
 #if defined(OS_WIN)
   typedef void* Handle;
 #elif defined(OS_POSIX)
   typedef pthread_t Handle;
 #endif
 
-  PlatformThreadHandle()
-      : handle_(0),
-        id_(0) {
-  }
+  PlatformThreadHandle() : handle_(0) {}
 
-  explicit PlatformThreadHandle(Handle handle)
-      : handle_(handle),
-        id_(0) {
-  }
-
-  PlatformThreadHandle(Handle handle,
-                       PlatformThreadId id)
-      : handle_(handle),
-        id_(id) {
-  }
-
-  // TODO(toyoshim): Remove id() and use PlatformThread::CurrentId() instead.
-  PlatformThreadId id() const {
-    return id_;
-  }
+  explicit PlatformThreadHandle(Handle handle) : handle_(handle) {}
 
   bool is_equal(const PlatformThreadHandle& other) const {
     return handle_ == other.handle_;
   }
 
   bool is_null() const {
     return !handle_;
   }
 
-  Handle platform_handle() const {
-    return handle_;
-  }
-
  private:
+  friend class MessagePumpForUI;
+  friend class PlatformThread;
+  friend class ThreadIdNameManager;

[gab, 2015/06/30 13:57:34]

I don't like using friend and I don't think I mind that the const
platform_handle() getter be usable outside of these classes (it's not really
useful there anyways).

Can we initially focus on getting rid of only id() and perhaps think about this
use case independently after if the exposure of the public const call is really
an issue?

[Takashi Toyoshima, 2015/07/02 06:34:28]

OK, let me upload another patch set.

   Handle handle_;
-  PlatformThreadId id_;
 };
 
 const PlatformThreadId kInvalidThreadId(0);
 
 // Valid values for priority of Thread::Options and SimpleThread::Options, and
 // SetCurrentThreadPriority(), listed in increasing order of importance.
 enum class ThreadPriority {
   // Suitable for threads that shouldn't disrupt high priority work.
   BACKGROUND,
   // Default priority level.
@@ skipping 80 matching lines @@
 
   static ThreadPriority GetCurrentThreadPriority();
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PlatformThread);
 };
 
 }  // namespace base
 
 #endif  // BASE_THREADING_PLATFORM_THREAD_H_