Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1207583002: Revert "Keep a canonical list of shared function infos." (Closed)

Created:
5 years, 6 months ago by adamk
Modified:
5 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev, Yang, Michael Hablich, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Keep a canonical list of shared function infos." Speculative revert in the hopes of fixing serializer crashes seen in canary. This reverts commit c1669450834436508e0007885eb7ac266cbcf083, as well as followup change "Do not look for existing shared function info when compiling a new script." (commit 7c43967bb73783b46c2ccf9cdd0fa716b74ce278). BUG=chromium:503552, v8:4132 TBR=yangguo@chromium.org LOG=n Committed: https://crrev.com/3164aa7483cb476da84895a3c9810015758fccf9 Cr-Commit-Position: refs/heads/master@{#29241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -209 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/ast.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.h View 3 chunks +4 lines, -8 lines 0 comments Download
M src/compiler.cc View 6 chunks +18 lines, -48 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 8 chunks +13 lines, -22 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/typing.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M test/mjsunit/regress/regress-4121.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
adamk
5 years, 6 months ago (2015-06-23 22:11:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207583002/1
5 years, 6 months ago (2015-06-23 22:11:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 22:59:29 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 22:59:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3164aa7483cb476da84895a3c9810015758fccf9
Cr-Commit-Position: refs/heads/master@{#29241}

Powered by Google App Engine
This is Rietveld 408576698